66892[TASK] Deprecate calling AbstractTreeView::getIcon() with records uid
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Georg Ringer +1
- Daniel Haupt +1
-
Verified V +2 Done
- Daniel Goerz +2
- Georg Ringer +1
- Daniel Haupt +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1114
-
Oli Bartsch uploaded patch set 1 11/24/20, 15:18
-
TYPO3com voted on patch set 1 V +1 11/24/20, 15:29 Completed build in 11m 01s on Tue, 24 Nov, 03:29 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7544
-
Oli Bartsch uploaded patch set 2 11/24/20, 15:33
-
TYPO3com voted on patch set 2 V +1 11/24/20, 15:44 Completed build in 10m 38s on Tue, 24 Nov, 03:44 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7545
-
Georg Ringer commented on patch set 2 V +1 CR +1 11/24/20, 17:41
-
Oli Bartsch uploaded patch set 3 11/24/20, 18:45
-
Oli Bartsch commented on patch set 3 11/24/20, 18:47
AbstractTreeView.php:645Reply UnresolvedYes, sure. Thanks. -
TYPO3com voted on patch set 3 V +1 11/24/20, 18:56 Completed build in 10m 39s on Tue, 24 Nov, 06:56 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7559
-
Georg Ringer voted on patch set 3 V +1 CR +1 11/24/20, 21:28
-
Tymoteusz Motylewski commented on patch set 3 11/25/20, 15:59
Do we have to deprecated it? is this class treated as api? -
Oli Bartsch commented on patch set 3 11/25/20, 16:01
> Patch Set 3: > > Do we have to deprecated it? is this class treated as api? Since the class is not marked as @internal and the method is public, I think we have to assume that this is used in 3rd party code. -
Daniel Haupt voted on patch set 3 V +1 CR +1 11/26/20, 20:53
-
Daniel Goerz voted on patch set 3 V +2 CR +2 11/27/20, 08:25
-
Daniel Goerz merged patch set 4 11/27/20, 08:25
AbstractTreeView.php:645