Review main Merged

66892[TASK] Deprecate calling AbstractTreeView::getIcon() with records uid

Oli Bartsch CR +2 V +2 Normal +52 −5 updated 11/27/20, 08:25

Commit message

Calling `AbstractTreeView::getIcon()` with the records uid as
first argument is deprecated. This helps to increase type safety
through the core and also properly reflects the expected value
for the parameter, as its name is `$row`.

Side note: There was no benefit in providing just the records uid
since the full record was fetched in that case anyways internally,
but without adding any restrictions or respecting any overlays.

Because the method returns a string in any case, the return type
is furthermore added to the method signature.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Daniel Haupt +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1114

  1. Oli Bartsch uploaded patch set 1 11/24/20, 15:18

  2. TYPO3com voted on patch set 1 V +1 11/24/20, 15:29 Completed build in 11m 01s on Tue, 24 Nov, 03:29 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7544

  3. Oli Bartsch uploaded patch set 2 11/24/20, 15:33

  4. TYPO3com voted on patch set 2 V +1 11/24/20, 15:44 Completed build in 10m 38s on Tue, 24 Nov, 03:44 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7545

  5. Georg Ringer commented on patch set 2 V +1 CR +1 11/24/20, 17:41

    AbstractTreeView.php:645

    shouldn't we remove that as well just to improve IDE support?
  6. Oli Bartsch uploaded patch set 3 11/24/20, 18:45

  7. Oli Bartsch commented on patch set 3 11/24/20, 18:47

    AbstractTreeView.php:645 Reply Unresolved

    Yes, sure. Thanks.
  8. TYPO3com voted on patch set 3 V +1 11/24/20, 18:56 Completed build in 10m 39s on Tue, 24 Nov, 06:56 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7559

  9. Georg Ringer voted on patch set 3 V +1 CR +1 11/24/20, 21:28

  10. Tymoteusz Motylewski commented on patch set 3 11/25/20, 15:59

    Do we have to deprecated it? is this class treated as api?
  11. Oli Bartsch commented on patch set 3 11/25/20, 16:01

    > Patch Set 3: > > Do we have to deprecated it? is this class treated as api? Since the class is not marked as @internal and the method is public, I think we have to assume that this is used in 3rd party code.
  12. Daniel Haupt voted on patch set 3 V +1 CR +1 11/26/20, 20:53

  13. Daniel Goerz voted on patch set 3 V +2 CR +2 11/27/20, 08:25

  14. Daniel Goerz merged patch set 4 11/27/20, 08:25