Review main Abandoned Breaking

66893[WIP][!!!][TASK] Update to Doctrine DBAL 3.0

Benni Mack CR 0 V 0 Hard +445 −141 updated 12/21/20, 12:21

Commit message

Doctrine DBAL decouples heavily from PDO. This is what
needs to be done:

* Our TYPO3 drivers need to become wrappers for the PDO drivers
  as the drivers are final now
* We need to create our own Result object to reimplement fetch() and fetchAll()
  and also make sure that StatementInterface still works, however this
  should not be used anymore (should be deprecated with a separate
  patch)
* Our Connection needs to create our own Result object (= code duplication)
* Document new behavior for prepared statements on how to use it (instead of bindParam() use setParameter() on querybuilder)
* Add DBALException and other exceptions as class aliases in our class alias loader
  But make sure to document that they should not be used anymore.

Review

  • Code review CR 0
  • Verified V 0

Files 12

Review log 47

  1. Benni Mack uploaded patch set 1 11/24/20, 16:26

  2. TYPO3com voted on patch set 1 V -1 11/24/20, 16:26 Completed build in 24s on Tue, 24 Nov, 04:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7547

  3. Benni Mack updated the commit message in patch set 2 11/24/20, 16:27

  4. TYPO3com voted on patch set 2 V -1 11/24/20, 16:27 Completed build in 21s on Tue, 24 Nov, 04:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7548

  5. Benni Mack uploaded patch set 3 11/25/20, 12:52

  6. TYPO3com voted on patch set 3 V -1 11/25/20, 12:55 Completed build in 03m 17s on Wed, 25 Nov, 12:55 PM Test Summary: 3 of 173 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7568

  7. Benni Mack abandoned the change 12/21/20, 12:21

    will not continue this approach anymore