Review main Merged

66895[TASK] Drop usages of TYPO3_MODE and TYPO3_REQUESTTYPE

Christian Kuhn CR +2 V +2 Hard +290 −119 updated 11/30/20, 12:12

Commit message

Drop all usages of TYPO3_MODE and TYPO3_REQUESTTYPE by
using the ApplicationType helper class when frontend
or backend is detected, and by directly using the
applicationType attribute of the request object in a
couple of special cases that check for backend ajax
or install tool.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Simon Gilli +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Simon Gilli +1
    • TYPO3com +1 CI

Issues 3

Files 45

Show 25 more files

Review log 2545

Show 1020 earlier messages
  1. Christian Kuhn uploaded patch set 1 11/24/20, 17:38

  2. TYPO3com voted on patch set 1 V -1 11/24/20, 17:39 Completed build in 33s on Tue, 24 Nov, 05:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7551

  3. Christian Kuhn uploaded patch set 2 11/24/20, 17:41

  4. TYPO3com voted on patch set 2 V -1 11/24/20, 17:52 Completed build in 10m 57s on Tue, 24 Nov, 05:52 PM Test Summary: 2854 of 32662 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7552

  5. TYPO3com commented on patch set 2 11/25/20, 12:47 Completed build in 10m 47s on Wed, 25 Nov, 12:47 PM Test Summary: 2311 of 32662 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7567

  6. Christian Kuhn uploaded patch set 3 11/25/20, 13:21

  7. TYPO3com voted on patch set 3 V -1 11/25/20, 13:34 Completed build in 12m 26s on Wed, 25 Nov, 01:34 PM Test Summary: 1782 of 32665 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7569

  8. Christian Kuhn uploaded patch set 4 11/26/20, 15:11

  9. Christian Kuhn uploaded patch set 5 11/26/20, 15:12

  10. TYPO3com voted on patch set 4 V -1 11/26/20, 15:12 Completed build in 27s on Thu, 26 Nov, 03:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7604

  11. Christian Kuhn uploaded patch set 6 11/26/20, 15:13

  12. Christian Kuhn uploaded patch set 7 11/26/20, 15:18

  13. TYPO3com voted on patch set 5 V -1 11/26/20, 15:23 Completed build in 11m 10s on Thu, 26 Nov, 03:23 PM Test Summary: 1155 of 32645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7605

  14. TYPO3com voted on patch set 6 V -1 11/26/20, 15:27 Completed build in 13m 21s on Thu, 26 Nov, 03:27 PM Test Summary: 1585 of 32645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7606

  15. TYPO3com voted on patch set 7 V -1 11/26/20, 15:31 Completed build in 11m 11s on Thu, 26 Nov, 03:31 PM Test Summary: 1896 of 32645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7607

  16. Christian Kuhn uploaded patch set 8 11/26/20, 16:02

  17. TYPO3com voted on patch set 8 V -1 11/26/20, 16:12 Completed build in 10m 35s on Thu, 26 Nov, 04:12 PM Test Summary: 1392 of 32645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7609

  18. Christian Kuhn uploaded patch set 9 11/28/20, 12:24

  19. TYPO3com voted on patch set 9 V -1 11/28/20, 12:36 Completed build in 11m 26s on Sat, 28 Nov, 12:36 PM Test Summary: 99 of 32645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7659

  20. Christian Kuhn uploaded patch set 10 11/28/20, 13:40

  1. TYPO3com voted on patch set 10 V +1 11/28/20, 13:52 Completed build in 11m 08s on Sat, 28 Nov, 01:52 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7660

  2. Christian Kuhn uploaded patch set 11 11/28/20, 14:03

  3. TYPO3com voted on patch set 11 V +1 11/28/20, 14:14 Completed build in 11m 12s on Sat, 28 Nov, 02:14 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7663

  4. Christian Kuhn uploaded patch set 12 11/28/20, 14:53

  5. TYPO3com voted on patch set 12 V -1 11/28/20, 15:04 Completed build in 10m 17s on Sat, 28 Nov, 03:04 PM Test Summary: 3 of 32645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7665

  6. Christian Kuhn uploaded patch set 13 11/28/20, 15:07

  7. TYPO3com voted on patch set 13 V +1 11/28/20, 15:18 Completed build in 10m 39s on Sat, 28 Nov, 03:18 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7666

  8. Christian Kuhn uploaded patch set 14 11/29/20, 10:25

  9. TYPO3com voted on patch set 14 V +1 11/29/20, 11:04 Completed build in 21m 49s on Sun, 29 Nov, 11:04 AM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7682

  10. Christian Kuhn uploaded patch set 15 11/29/20, 13:16

  11. TYPO3com voted on patch set 15 V +1 11/29/20, 13:27 Completed build in 11m 32s on Sun, 29 Nov, 01:27 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7685

  12. Christian Kuhn uploaded patch set 16 11/29/20, 15:41

  13. TYPO3com voted on patch set 16 V +1 11/29/20, 15:54 Completed build in 11m 54s on Sun, 29 Nov, 03:54 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7687

  14. Christian Kuhn uploaded patch set 17 11/30/20, 09:08

  15. TYPO3com voted on patch set 17 V -1 11/30/20, 09:09 Completed build in 29s on Mon, 30 Nov, 09:09 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7689

  16. Christian Kuhn uploaded patch set 18 11/30/20, 09:09

  17. TYPO3com voted on patch set 18 V +1 11/30/20, 09:21 Completed build in 11m 01s on Mon, 30 Nov, 09:21 AM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7690

  18. Simon Gilli commented on patch set 18 CR -1 11/30/20, 10:37

    Review in progress...
  19. Simon Gilli voted on patch set 18 CR +1 11/30/20, 11:38

  20. Oli Bartsch uploaded patch set 19 11/30/20, 11:38

  21. TYPO3com voted on patch set 19 V +1 11/30/20, 11:52 Completed build in 11m 24s on Mon, 30 Nov, 11:52 AM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7695

  22. Simon Gilli commented on patch set 19 V +1 CR +1 11/30/20, 11:53

    Looks good, no problems found so far.
  23. Oli Bartsch voted on patch set 19 V +1 CR +1 11/30/20, 11:54

  24. Benni Mack commented on patch set 19 V +2 CR +2 11/30/20, 12:12

    nice work.
  25. Benni Mack merged patch set 20 11/30/20, 12:12