Review main Merged

66902[BUGFIX] Fix performance issue with mail spools

Markus Gerdes CR +2 V +2 Easy +2 −17 updated 11/26/20, 06:58

Commit message

This patch removes the concatenation of the queued messages of the
spools in the __toString() methods which is needed for newer Symfony
releases.

Instead a simple identifier for representing the spool is returned.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Markus Gerdes uploaded patch set 1 11/25/20, 16:54

  2. Simon Gilli commented on patch set 1 11/25/20, 16:57

    @benni Like discussed via PM here the change
  3. Simon Gilli updated the commit message in patch set 2 11/25/20, 17:01

  4. TYPO3com voted on patch set 1 V +1 11/25/20, 17:06 Completed build in 12m 08s on Wed, 25 Nov, 05:06 PM Test Summary: 32394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7577

  5. Simon Gilli commented on patch set 2 V +1 CR +1 11/25/20, 17:10

    Thanks for this fix Markus!
  6. TYPO3com voted on patch set 2 V +1 11/25/20, 17:12 Completed build in 11m 12s on Wed, 25 Nov, 05:12 PM Test Summary: 32394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7578

  7. Benni Mack voted on patch set 2 V +2 CR +2 11/26/20, 06:58

  8. Benni Mack merged patch set 3 11/26/20, 06:58