66906[TASK] Always send 404 response on hidden pages
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 3
Files 11
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/createPageNContentWDefaults.csvnew+17 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+40 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/AbstractActionTestCase.php+30 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+10 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/PlainScenario.yaml+1 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/SlugScenario.yaml+1 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+44 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+44 −0
- typo3/sysext/seo/Tests/Functional/Canonical/CanonicalGeneratorTest.php+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/createPageNContentWDefaults.csvnew+23 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+35 −0
Review log 1016
-
Claus Due uploaded patch set 1 11/26/20, 09:27
-
Claus Due wrote 11/26/20, 09:29
Topic set to DataHandler -
Claus Due updated the commit message in patch set 2 11/26/20, 09:30
-
TYPO3com voted on patch set 1 V -1 11/26/20, 09:39 Completed build in 12m 23s on Thu, 26 Nov, 09:39 AM Test Summary: 9 of 75927 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-928
-
TYPO3com voted on patch set 2 V -1 11/26/20, 09:42 Completed build in 11m 27s on Thu, 26 Nov, 09:42 AM Test Summary: 9 of 75927 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-929
-
Sybille Peters commented on patch set 2 11/26/20, 09:43
Just a question: what will be the correct behaviour in the future? 404 - on hidden pages 403 - on pages with access restriction (e.g. page has FE group assigned) ? Just want to make sure because it sounds as if you want to send 404 for the pages with access restriction too. That does not seem right. -
Claus Due uploaded patch set 3 11/26/20, 09:53
-
Claus Due commented on patch set 3 11/26/20, 10:02
> Just want to make sure because it sounds as if you want to send 404 for the pages with access restriction too. That does not seem right. FYI this is a backport so this behavior is already in 10.4 and master. We want 404 for a hidden page regardless of access restrictions. Currently, a 403 is dispatched on 9.5. -
TYPO3com voted on patch set 3 V -1 11/26/20, 10:05 Completed build in 11m 53s on Thu, 26 Nov, 10:05 AM Test Summary: 9 of 75927 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-930
-
Claus Due uploaded patch set 4 11/26/20, 10:13
-
TYPO3com voted on patch set 4 V -1 11/26/20, 10:27 Completed build in 14m 19s on Thu, 26 Nov, 10:27 AM Test Summary: 9 of 75927 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-931
-
Claus Due uploaded patch set 5 03/25/21, 10:51
-
TYPO3com voted on patch set 5 V -1 03/25/21, 11:10 Completed build in 18m 12s on Thu, 25 Mar, 11:10 AM Test Summary: 6 of 75941 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1046
-
core-ci voted on patch set 5 V -1 03/25/21, 11:20 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1829
-
Benni Mack wrote 04/27/21, 19:27
Removed reviewer Benni Mack. -
Benni Mack abandoned the change 10/08/21, 07:59
No public 9.5 LTS releases anymore, should go into ELTS team if still needed.