Review main Merged

66907[DOCS] Fix hook registration example in changelog

TYPO3com CR +2 V +2 Easy +2 −2 updated 11/26/20, 13:30

Commit message

The `makeSearchStringConstraints` hook in DatabaseRecordList
expects a class name to be given as value. The method to
be called on the instantiated hook object is fix and can
not be provided in the hook registration.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 711

  1. TYPO3com uploaded patch set 1 11/26/20, 10:13

  2. TYPO3com voted on patch set 1 V +1 11/26/20, 10:25 Completed build in 11m 53s on Thu, 26 Nov, 10:25 AM Test Summary: 32394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7588

  3. Oli Bartsch uploaded patch set 2 11/26/20, 10:47

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 11/26/20, 10:48

  5. TYPO3com voted on patch set 2 V +1 11/26/20, 10:58 Completed build in 10m 31s on Thu, 26 Nov, 10:58 AM Test Summary: 32394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7590

  6. Christian Kuhn commented on patch set 2 11/26/20, 11:57

    since this is a v9 file ... backport to v10 & v9 needed?
  7. Oli Bartsch updated the commit message in patch set 3 11/26/20, 12:03

  8. Oli Bartsch commented on patch set 3 V +1 CR +1 11/26/20, 12:04

    > Patch Set 2: > > since this is a v9 file ... backport to v10 & v9 needed?
  9. TYPO3com voted on patch set 3 V +1 11/26/20, 12:16 Completed build in 12m 15s on Thu, 26 Nov, 12:16 PM Test Summary: 32394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7592

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 11/26/20, 13:30

  11. Christian Kuhn merged patch set 4 11/26/20, 13:30