Review main Merged

66933[BUGFIX] Handle sorting of nested IRRE containers properly

Andreas Kienast CR +2 V +2 Easy +4 −2 updated 01/06/21, 11:34

Commit message

When sorting elements in an IRRE container, the sorting took
grandchildren into account as well, which broke the sorting in the
database.

With this patch, a new data attribute is added to be able to identify
direct ancestors and limit sorting to these records only.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Guido Schmechel +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1317

  1. Andreas Kienast uploaded patch set 1 11/27/20, 11:54

  2. TYPO3com voted on patch set 1 V -1 11/27/20, 12:05 Completed build in 11m 02s on Fri, 27 Nov, 12:05 PM Test Summary: 32394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7644

  3. Andreas Kienast uploaded patch set 2 11/27/20, 12:09

  4. TYPO3com voted on patch set 2 V +1 11/27/20, 12:20 Completed build in 11m 01s on Fri, 27 Nov, 12:20 PM Test Summary: 32394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7645

  5. Daniel Goerz voted on patch set 2 CR +1 11/27/20, 14:16

  6. Johannes Schlier voted on patch set 2 CR +1 11/27/20, 14:39

  7. Guido Schmechel commented on patch set 2 V +1 CR +1 11/27/20, 18:40

    Solves my specific case. Two layers in flex form nested into each other. Both use records of type inline based on IRRE
  8. Markus Klein commented on patch set 2 12/13/20, 13:51

  9. Andreas Kienast commented on patch set 2 12/13/20, 14:36

    Reply

    No, this patch only takes care that the correct children IDs are sent to the server, this is unrelated to DataHandler.
  10. Andreas Kienast uploaded patch set 3 12/23/20, 06:49

  11. TYPO3com voted on patch set 3 V +1 12/23/20, 07:00 Completed build in 10m 24s on Wed, 23 Dec, 07:00 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8449

  12. Andreas Kienast uploaded patch set 4 12/31/20, 11:30

  13. TYPO3com voted on patch set 4 V +1 12/31/20, 11:42 Completed build in 11m 16s on Thu, 31 Dec, 11:42 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8524

  14. Richard Haeser voted on patch set 4 V +1 CR +1 01/02/21, 07:55

  15. Guido Schmechel voted on patch set 4 CR +1 01/03/21, 11:30

  16. Andreas Kienast voted on patch set 4 V +2 CR +2 01/06/21, 11:34

  17. Andreas Kienast merged patch set 5 01/06/21, 11:34