Review main Merged Breaking

66935[!!!][FEATURE] Refactored Session Handling

Benni Mack CR +2 V +2 Expert +1706 −593 updated 12/12/20, 13:23

Commit message

The AbstractUserAuthentication class handles way too much
of what it should know / do.

For this reason, a new UserSession object which contains
basic information needed for everything belonging to a non-fixated
session, a fixated anonymous session, if a session was evelated,
or if a session has expired, is kept in there.
The "SessionManager" should not be used anymore publically
but slowly dissolve into a SessionBackendManager.

Design goals:
* UserAuth object should not know about session backends
* UserAuth should not store sessionData etc. directly in its own object
* Decouple UserSession info from any properties of UserAuth
* A UserSessionManager deals with the creation and validation of the UserSession objects. No Session Objects can be created etc outside
of this class to maintain persistability
* UserSessionManager also encapsulates ipLocking and the responsible SessionBackend

Final goals to be tackled later:
* Build a user session object from the request object, and not within the UserAuth object
* Session Handling can be accessed outside of UserAuth
* Cookie Handling and Session Handling are separated from UserAuth
* Load Session information from PSR-7 request instead of $_COOKIE

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 39

Show 19 more files

Review log 71127

Show 53102 earlier messages
  1. Benni Mack uploaded patch set 1 11/27/20, 16:41

  2. TYPO3com voted on patch set 1 V -1 11/27/20, 16:50 Completed build in 08m 39s on Fri, 27 Nov, 04:50 PM Test Summary: 10894 of 32635 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7651

  3. Benni Mack uploaded patch set 2 11/27/20, 17:50

  4. Benni Mack uploaded patch set 3 11/27/20, 17:55

  5. TYPO3com voted on patch set 2 V -1 11/27/20, 17:58 Completed build in 08m 17s on Fri, 27 Nov, 05:58 PM Test Summary: 9673 of 32635 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7652

  6. TYPO3com voted on patch set 3 V -1 11/27/20, 18:04 Completed build in 08m 55s on Fri, 27 Nov, 06:04 PM Test Summary: 9654 of 32635 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7654

  7. Benni Mack uploaded patch set 4 11/28/20, 14:00

  8. TYPO3com voted on patch set 4 V -1 11/28/20, 14:09 Completed build in 08m 52s on Sat, 28 Nov, 02:09 PM Test Summary: 10216 of 32635 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7662

  9. Benni Mack uploaded patch set 5 11/28/20, 14:12

  10. TYPO3com voted on patch set 5 V -1 11/28/20, 14:20 Completed build in 08m 15s on Sat, 28 Nov, 02:20 PM Test Summary: 9651 of 32635 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7664

  11. Oli Bartsch uploaded patch set 6 12/01/20, 20:47

  12. Oli Bartsch uploaded patch set 7 12/01/20, 20:53

  13. TYPO3com voted on patch set 6 V -1 12/01/20, 20:56 Completed build in 08m 41s on Tue, 1 Dec, 08:56 PM Test Summary: 9795 of 32646 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7738

  14. TYPO3com voted on patch set 7 V -1 12/01/20, 21:04 Completed build in 10m 52s on Tue, 1 Dec, 09:04 PM Test Summary: 9515 of 31907 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7739

  15. Benni Mack uploaded patch set 8 12/03/20, 13:44

  16. TYPO3com voted on patch set 8 V -1 12/03/20, 13:53 Completed build in 09m 24s on Thu, 3 Dec, 01:53 PM Test Summary: 8555 of 30653 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7759

  17. Benni Mack uploaded patch set 9 12/03/20, 14:06

  18. TYPO3com voted on patch set 9 V -1 12/03/20, 14:14 Completed build in 07m 54s on Thu, 3 Dec, 02:14 PM Test Summary: 10047 of 32646 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7760

  19. Benni Mack uploaded patch set 10 12/03/20, 14:15

  20. TYPO3com voted on patch set 10 V -1 12/03/20, 14:24 Completed build in 09m 02s on Thu, 3 Dec, 02:24 PM Test Summary: 10070 of 32646 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7761

  21. Benni Mack uploaded patch set 11 12/03/20, 15:24

  22. TYPO3com voted on patch set 11 V -1 12/03/20, 15:33 Completed build in 08m 42s on Thu, 3 Dec, 03:33 PM Test Summary: 9582 of 32646 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7762

  23. Benni Mack uploaded patch set 12 12/03/20, 16:12

  24. TYPO3com voted on patch set 12 V -1 12/03/20, 16:12 Completed build in 20s on Thu, 3 Dec, 04:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7764

  25. Benni Mack uploaded patch set 13 12/03/20, 16:17

  26. TYPO3com voted on patch set 13 V -1 12/03/20, 16:18 Completed build in 25s on Thu, 3 Dec, 04:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7765

  27. Benni Mack uploaded patch set 14 12/04/20, 07:08

  28. TYPO3com voted on patch set 14 V -1 12/04/20, 07:17 Completed build in 08m 36s on Fri, 4 Dec, 07:17 AM Test Summary: 9444 of 32646 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7768

  29. Benni Mack uploaded patch set 15 12/04/20, 08:17

  30. TYPO3com voted on patch set 15 V -1 12/04/20, 08:26 Completed build in 08m 31s on Fri, 4 Dec, 08:26 AM Test Summary: 3119 of 32646 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7770

  31. Benni Mack uploaded patch set 16 12/04/20, 09:20

  32. TYPO3com voted on patch set 16 V -1 12/04/20, 09:22 Completed build in 25s on Fri, 4 Dec, 09:22 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7773

  33. Benni Mack uploaded patch set 17 12/04/20, 09:36

  34. TYPO3com voted on patch set 17 V -1 12/04/20, 09:45 Completed build in 09m 00s on Fri, 4 Dec, 09:45 AM Test Summary: 5 of 32646 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7775

  35. Benni Mack uploaded patch set 18 12/04/20, 10:56

  36. TYPO3com voted on patch set 18 V -1 12/04/20, 11:05 Completed build in 08m 53s on Fri, 4 Dec, 11:05 AM Test Summary: 5 of 32646 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7778

  37. Benni Mack uploaded patch set 19 12/04/20, 12:21

  38. TYPO3com voted on patch set 19 V -1 12/04/20, 12:30 Completed build in 08m 48s on Fri, 4 Dec, 12:30 PM Test Summary: 10 of 32646 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7780

  39. Benni Mack uploaded patch set 20 12/04/20, 19:56

  40. TYPO3com voted on patch set 20 V -1 12/04/20, 20:09 Completed build in 12m 30s on Fri, 4 Dec, 08:09 PM Test Summary: 10 of 32656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7810

  41. Benni Mack uploaded patch set 21 12/05/20, 11:42

  42. TYPO3com voted on patch set 21 V -1 12/05/20, 11:51 Completed build in 08m 27s on Sat, 5 Dec, 11:51 AM Test Summary: 10 of 32656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7824

  43. Benni Mack uploaded patch set 22 12/07/20, 09:13

  44. TYPO3com voted on patch set 22 V -1 12/07/20, 09:24 Completed build in 11m 00s on Mon, 7 Dec, 09:24 AM Test Summary: 10 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7892

  45. Oli Bartsch uploaded patch set 23 12/07/20, 11:04

  46. TYPO3com voted on patch set 23 V -1 12/07/20, 11:15 Completed build in 10m 32s on Mon, 7 Dec, 11:15 AM Test Summary: 1 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7897

  47. Benni Mack uploaded patch set 24 12/07/20, 12:44

  48. TYPO3com voted on patch set 24 V -1 12/07/20, 12:53 Completed build in 09m 02s on Mon, 7 Dec, 12:53 PM Test Summary: 1 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7901

  49. Benni Mack uploaded patch set 25 12/07/20, 13:58

  50. TYPO3com voted on patch set 25 V +1 12/07/20, 14:13 Completed build in 15m 05s on Mon, 7 Dec, 02:13 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7907

  51. Oli Bartsch uploaded patch set 26 12/07/20, 14:16

  52. TYPO3com voted on patch set 26 V -1 12/07/20, 14:27 Completed build in 11m 03s on Mon, 7 Dec, 02:27 PM Test Summary: 32399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7909

  53. TYPO3com voted on patch set 26 V +1 12/07/20, 14:36 Completed build in 31m 39s on Mon, 7 Dec, 02:36 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7909

  54. Benni Mack uploaded patch set 27 12/07/20, 16:56

  55. TYPO3com voted on patch set 27 V -1 12/07/20, 17:19 Completed build in 21m 22s on Mon, 7 Dec, 05:18 PM Test Summary: 4 of 32653 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7928

  56. Oli Bartsch uploaded patch set 28 12/07/20, 17:59

  57. TYPO3com voted on patch set 28 V -1 12/07/20, 18:09 Completed build in 10m 16s on Mon, 7 Dec, 06:09 PM Test Summary: 31161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7934

  58. TYPO3com voted on patch set 28 V +1 12/07/20, 18:21 Completed build in 10m 04s on Mon, 7 Dec, 06:21 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7935

  59. Oli Bartsch uploaded patch set 29 12/07/20, 18:36

  60. TYPO3com voted on patch set 29 V +1 12/07/20, 18:46 Completed build in 09m 18s on Mon, 7 Dec, 06:46 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7937

  61. Oli Bartsch uploaded patch set 30 12/07/20, 22:55

  62. Oli Bartsch uploaded patch set 31 12/08/20, 08:33

  63. TYPO3com voted on patch set 31 V +1 12/08/20, 08:49 Completed build in 11m 59s on Tue, 8 Dec, 08:49 AM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7951

  64. Benni Mack uploaded patch set 32 12/08/20, 09:18

  65. Benni Mack uploaded patch set 33 12/08/20, 09:27

  66. TYPO3com voted on patch set 32 V +1 12/08/20, 09:28 Completed build in 10m 01s on Tue, 8 Dec, 09:28 AM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7953

  67. TYPO3com voted on patch set 33 V -1 12/08/20, 09:38 Completed build in 10m 36s on Tue, 8 Dec, 09:38 AM Test Summary: 4 of 30815 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7954

  68. Oli Bartsch uploaded patch set 34 12/08/20, 11:23

  69. TYPO3com voted on patch set 34 V -1 12/08/20, 11:33 Completed build in 10m 16s on Tue, 8 Dec, 11:33 AM Test Summary: 4 of 32652 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7956

  70. Oli Bartsch uploaded patch set 35 12/08/20, 11:57

  71. TYPO3com voted on patch set 35 V -1 12/08/20, 12:08 Completed build in 10m 55s on Tue, 8 Dec, 12:08 PM Test Summary: 4 of 32652 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7958

  72. Oli Bartsch uploaded patch set 36 12/08/20, 13:05

  73. TYPO3com voted on patch set 36 V +1 12/08/20, 13:14 Completed build in 09m 00s on Tue, 8 Dec, 01:14 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7963

  74. Oli Bartsch uploaded patch set 37 12/08/20, 15:59

  75. TYPO3com voted on patch set 37 V -1 12/08/20, 16:10 Completed build in 10m 39s on Tue, 8 Dec, 04:10 PM Test Summary: 30428 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7967

  76. Benni Mack commented on patch set 37 12/08/20, 16:33

    SetupModuleController.php:849

    I wonder why we don't use isSystemMaintainer()
  77. Oli Bartsch commented on patch set 37 12/08/20, 16:47

    SetupModuleController.php:849 Reply

    AFAICS because isSystemMaintainer returns false if in switch-user mode. Therefore the check in 850 would not work and the password fields would be displayed.
  78. Benni Mack commented on patch set 37 12/08/20, 16:56

    SetupModuleController.php:849 Reply

    good point. thx.
  79. Oli Bartsch uploaded patch set 38 12/08/20, 19:36

  80. TYPO3com voted on patch set 38 V -1 12/08/20, 19:38 Completed build in 01m 52s on Tue, 8 Dec, 07:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7973

  81. Oli Bartsch uploaded patch set 39 12/08/20, 21:27

  82. TYPO3com voted on patch set 39 V +1 12/08/20, 21:36 Completed build in 08m 47s on Tue, 8 Dec, 09:36 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7975

  83. Oli Bartsch uploaded patch set 40 12/08/20, 21:38

  84. TYPO3com voted on patch set 40 V +1 12/08/20, 21:47 Completed build in 09m 19s on Tue, 8 Dec, 09:47 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7976

  85. Benni Mack uploaded patch set 41 12/08/20, 21:57

  86. Benni Mack uploaded patch set 42 12/08/20, 22:05

  87. TYPO3com voted on patch set 42 V -1 12/08/20, 22:05 Completed build in 28s on Tue, 8 Dec, 10:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7978

  88. TYPO3com voted on patch set 41 V -1 12/08/20, 22:08 Completed build in 10m 53s on Tue, 8 Dec, 10:08 PM Test Summary: 2 of 32290 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7977

  89. Oli Bartsch uploaded patch set 43 12/08/20, 22:21

  90. TYPO3com voted on patch set 43 V -1 12/08/20, 22:22 Completed build in 30s on Tue, 8 Dec, 10:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7979

  91. Oli Bartsch uploaded patch set 44 12/08/20, 22:48

  92. TYPO3com voted on patch set 44 V -1 12/08/20, 23:00 Completed build in 11m 32s on Tue, 8 Dec, 11:00 PM Test Summary: 32041 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7980

  93. Benni Mack uploaded patch set 45 12/09/20, 10:46

  94. Oli Bartsch uploaded patch set 46 12/09/20, 10:54

  95. TYPO3com voted on patch set 45 V -1 12/09/20, 10:58 Completed build in 11m 52s on Wed, 9 Dec, 10:58 AM Test Summary: 472 of 32280 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7982

  96. Oli Bartsch uploaded patch set 47 12/09/20, 11:11

  97. Oli Bartsch uploaded patch set 48 12/09/20, 11:15

  98. TYPO3com voted on patch set 47 V -1 12/09/20, 11:21 Completed build in 09m 59s on Wed, 9 Dec, 11:21 AM Test Summary: 1552 of 27855 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7985

  99. TYPO3com voted on patch set 48 V -1 12/09/20, 11:24 Completed build in 08m 50s on Wed, 9 Dec, 11:24 AM Test Summary: 1477 of 31207 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7986

  100. Benni Mack uploaded patch set 49 12/09/20, 13:44

  101. TYPO3com voted on patch set 49 V -1 12/09/20, 13:54 Completed build in 10m 33s on Wed, 9 Dec, 01:54 PM Test Summary: 8993 of 32562 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7996

  102. Benni Mack uploaded patch set 50 12/09/20, 14:30

  1. TYPO3com voted on patch set 50 V +1 12/09/20, 14:44 Completed build in 12m 24s on Wed, 9 Dec, 02:44 PM Test Summary: 32423 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8001

  2. Oli Bartsch uploaded patch set 51 12/09/20, 14:45

  3. TYPO3com voted on patch set 51 V +1 12/09/20, 14:55 Completed build in 09m 50s on Wed, 9 Dec, 02:55 PM Test Summary: 32423 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8002

  4. Christian Kuhn commented on patch set 51 12/09/20, 15:17

    first read - stumbled upon some methods that sound rather odd ... naming things ;) maybe we could improve some. will continue with a more deep analysis.

    UserSession.php:49

    possible to protect this to force usage of factory methods? (i did that with class ApplicationType recently).

    UserSession.php:159

    dataWasUpdated() / dataHasBeenUpdated() / ... ?

    UserSession.php:223

    nitpick: i'd prefer to have those factory methods and toArray() on top in the file - after __construct() at best.

    UserSessionManager.php:40

    sounds quite outdated. imho: remove ... this is a constant now and 32 shouldn't be changed anyway ...

    UserSessionManager.php:53

    out of curiosity: is session lifetime < 0 actually used, and if so, what for? (Instant logout after login sounds like a hack that works around something else that is broken).

    UserSessionManager.php:262

    sounds odd. do you mean isSessionPersisted() ?

    UserSessionManager.php:272

    maybe updatePersistedSessionData() ?

    UserSessionManager.php:343

    nitpick: I'd prefer to have those factory methods below or after top __construct()
  5. Benni Mack uploaded patch set 52 12/09/20, 15:18

  6. TYPO3com voted on patch set 52 V -1 12/09/20, 15:31 Completed build in 12m 36s on Wed, 9 Dec, 03:31 PM Test Summary: 31600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8003

  7. Benni Mack commented on patch set 52 12/09/20, 16:53

    UserSession.php:223 Reply

    I don't. What to do? ;)

    UserSessionManager.php:343 Reply

    I don't. What to do? ;)
  8. TYPO3com voted on patch set 52 V +1 12/09/20, 16:59 Completed build in 1h 53m 12s on Wed, 9 Dec, 04:59 PM Test Summary: 32423 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8003

  9. Christian Kuhn commented on patch set 52 12/09/20, 17:12

    UserSession.php:223 Reply

    ignore my preference, then. it's not crucially important ;)

    UserSessionManager.php:343 Reply

    ignore my preference, then. it's not crucially important ;)
  10. Benni Mack uploaded patch set 53 12/09/20, 19:38

  11. TYPO3com voted on patch set 53 V -1 12/09/20, 19:50 Completed build in 11m 07s on Wed, 9 Dec, 07:50 PM Test Summary: 435 of 32664 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8008

  12. Benni Mack uploaded patch set 54 12/09/20, 20:47

  13. TYPO3com voted on patch set 54 V +1 12/09/20, 20:56 Completed build in 09m 41s on Wed, 9 Dec, 08:56 PM Test Summary: 32423 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8010

  14. Benni Mack uploaded patch set 55 12/10/20, 08:06

  15. TYPO3com voted on patch set 55 V +1 12/10/20, 08:16 Completed build in 09m 06s on Thu, 10 Dec, 08:16 AM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8013

  16. Oli Bartsch voted on patch set 55 V +1 CR +1 12/10/20, 08:52

  17. Benni Mack commented on patch set 55 12/10/20, 08:54

    UserSession.php:49 Reply

    Ack

    UserSession.php:159 Reply

    Ack

    UserSession.php:223 Reply

    thx

    UserSessionManager.php:40 Reply

    Ack

    UserSessionManager.php:53 Reply

    Ack

    UserSessionManager.php:262 Reply

    Ack

    UserSessionManager.php:272 Reply

    Ack

    UserSessionManager.php:343 Reply

    thx
  18. Christian Kuhn commented on patch set 55 CR -1 12/10/20, 09:37

    on it.
  19. Christian Kuhn voted on patch set 55 V +1 CR +1 12/10/20, 12:08

  20. Benni Mack voted on patch set 55 V +2 CR +2 12/10/20, 12:09

  21. Benni Mack merged patch set 56 12/10/20, 12:09

  22. Benni Mack commented on patch set 56 12/11/20, 17:26

    AbstractUserAuthentication.php:789 Unresolved

    unserialize() is now stricter than before, not showing flash messages anymore.

    AbstractUserAuthentication.php:874 Unresolved

    unserialize() is now stricter than before, not showing flash messages anymore.

    UserSession.php:229 Unresolved

    unserialize() is now stricter than before, not showing flash messages anymore.
  23. Benni Mack commented on patch set 56 12/11/20, 21:35

    AbstractUserAuthentication.php:598 Unresolved

    Regression: This is now the other way around.

    AbstractUserAuthentication.php:643 Unresolved

    we left out the session check here $tempuser['ses_id'] != $this->id
  24. Markus Klein commented on patch set 56 12/11/20, 21:41

    AbstractUserAuthentication.php:455 Unresolved

    typo: timed

    UserSession.php:35 Unresolved

    missing text?
  25. Markus Klein commented on patch set 56 12/12/20, 09:53

    AbstractUserAuthentication.php:587 Unresolved

    missing (int) cast. depending on data source of $tempuser we might get a string