Review main Merged

66936[TASK] Make ClassSchema PHP 8 compatible

Alexander Schnitzler CR +2 V +2 Easy +35 −8 updated 03/15/21, 16:14

Commit message

Several reflection methods are deprecated for a while
and throw errors with PHP8.

- ReflectionParameter::getClass()
- ReflectionParameter::isArray()

Both need to be replaced with the new api:

- ReflectionParameter::getType()

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 4

Review log 1623

  1. Alexander Schnitzler uploaded patch set 1 11/28/20, 15:31

  2. Alexander Schnitzler wrote 11/28/20, 15:31

    Topic set to extbase
  3. Alexander Schnitzler wrote 11/28/20, 15:31

    Hashtag added: php8
  4. Alexander Schnitzler wrote 11/28/20, 15:32

    Hashtag added: reflection
  5. TYPO3com voted on patch set 1 V -1 11/28/20, 15:42 Completed build in 10m 41s on Sat, 28 Nov, 03:42 PM Test Summary: 32396 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7667

  6. Alexander Schnitzler uploaded patch set 2 11/28/20, 15:44

  7. TYPO3com voted on patch set 2 V -1 11/28/20, 15:55 Completed build in 11m 29s on Sat, 28 Nov, 03:55 PM Test Summary: 32396 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7668

  8. Alexander Schnitzler uploaded patch set 3 11/28/20, 16:02

  9. TYPO3com voted on patch set 3 V +1 11/28/20, 16:14 Completed build in 11m 32s on Sat, 28 Nov, 04:14 PM Test Summary: 32396 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7670

  10. Benni Mack commented on patch set 3 12/04/20, 06:10

    Hey Alex, can you update the patch and also mark this change to be backported as well? Thanks. Benni.
  11. Alexander Schnitzler commented on patch set 3 12/04/20, 08:26

    Reply

    Yes, but it's not ready yet.
  12. Benni Mack uploaded patch set 4 01/04/21, 10:32

  13. Benni Mack updated the commit message in patch set 5 01/04/21, 10:32

  14. TYPO3com voted on patch set 4 V +1 01/04/21, 10:42 Completed build in 10m 25s on Mon, 4 Jan, 10:42 AM Test Summary: 32548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8583

  15. TYPO3com voted on patch set 5 V +1 01/04/21, 10:45 Completed build in 12m 21s on Mon, 4 Jan, 10:45 AM Test Summary: 32548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8584

  16. Benni Mack marked it ready for review 01/05/21, 12:59

  17. Benni Mack uploaded patch set 6 03/01/21, 17:47

  18. TYPO3com voted on patch set 6 V +1 03/01/21, 17:54 Completed build in 07m 08s on Mon, 1 Mar, 05:54 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9787

  19. core-ci voted on patch set 6 V +1 03/01/21, 17:58 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1095

  20. Christian Kuhn voted on patch set 6 V +1 CR +1 03/01/21, 18:10

  21. Benni Mack voted on patch set 6 V +2 CR +2 03/01/21, 19:08

  22. Benni Mack merged patch set 7 03/01/21, 19:08

  23. Benni Mack wrote 03/15/21, 16:14

    Created a revert of this change as I141e100a1dcbfe6c2d9b41af090c1c120052a8f4