66936[TASK] Make ClassSchema PHP 8 compatible
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+17 −8
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/MethodParameterTest.php+13 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfMethods.php+4 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+1 −0
Review log 1623
-
Alexander Schnitzler uploaded patch set 1 11/28/20, 15:31
-
Alexander Schnitzler wrote 11/28/20, 15:31
Topic set to extbase -
Alexander Schnitzler wrote 11/28/20, 15:31
Hashtag added: php8 -
Alexander Schnitzler wrote 11/28/20, 15:32
Hashtag added: reflection -
TYPO3com voted on patch set 1 V -1 11/28/20, 15:42 Completed build in 10m 41s on Sat, 28 Nov, 03:42 PM Test Summary: 32396 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7667
-
Alexander Schnitzler uploaded patch set 2 11/28/20, 15:44
-
TYPO3com voted on patch set 2 V -1 11/28/20, 15:55 Completed build in 11m 29s on Sat, 28 Nov, 03:55 PM Test Summary: 32396 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7668
-
Alexander Schnitzler uploaded patch set 3 11/28/20, 16:02
-
TYPO3com voted on patch set 3 V +1 11/28/20, 16:14 Completed build in 11m 32s on Sat, 28 Nov, 04:14 PM Test Summary: 32396 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7670
-
Benni Mack commented on patch set 3 12/04/20, 06:10
Hey Alex, can you update the patch and also mark this change to be backported as well? Thanks. Benni. -
Alexander Schnitzler commented on patch set 3 12/04/20, 08:26
Reply
Yes, but it's not ready yet. -
Benni Mack uploaded patch set 4 01/04/21, 10:32
-
Benni Mack updated the commit message in patch set 5 01/04/21, 10:32
-
TYPO3com voted on patch set 4 V +1 01/04/21, 10:42 Completed build in 10m 25s on Mon, 4 Jan, 10:42 AM Test Summary: 32548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8583
-
TYPO3com voted on patch set 5 V +1 01/04/21, 10:45 Completed build in 12m 21s on Mon, 4 Jan, 10:45 AM Test Summary: 32548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8584
-
Benni Mack marked it ready for review 01/05/21, 12:59
-
Benni Mack uploaded patch set 6 03/01/21, 17:47
-
TYPO3com voted on patch set 6 V +1 03/01/21, 17:54 Completed build in 07m 08s on Mon, 1 Mar, 05:54 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9787
-
core-ci voted on patch set 6 V +1 03/01/21, 17:58 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1095
-
Christian Kuhn voted on patch set 6 V +1 CR +1 03/01/21, 18:10
-
Benni Mack voted on patch set 6 V +2 CR +2 03/01/21, 19:08
-
Benni Mack merged patch set 7 03/01/21, 19:08
-
Benni Mack wrote 03/15/21, 16:14
Created a revert of this change as I141e100a1dcbfe6c2d9b41af090c1c120052a8f4