Review main Merged

66937[TASK] Introduce constant 'TYPO3'

Christian Kuhn CR +2 V +2 Easy +6 −0 updated 11/28/20, 17:36

Commit message

TYPO3 still has some script files that run in global scope
without class or callable encapsulation. Those are especially
ext_localconf.php, ext_tables.php and Configuration/TCA/Overrides/*
script files.

When those files are located within document root, they can be
called directly via HTTP and may output something, which can be
a security risk. To prevent this, they have a call at the very
start: 'defined('TYPO3_MODE') or die();'.

Unfortunately, constant 'TYPO3_MODE' is a technical debt, core
tries to phase it out in v11. We thus need something equivalent
for these calls.

Since that test for existance of a constant is so simple and
straight forward, the solution is to define a new constant to
true, simply named 'TYPO3', to substitute 'TYPO3_MODE'. The
call is very similar: 'defined('TYPO3') or die();'.

The patch targets core master and v10: Having that constant in
v10 simplifies life of extension developers who want to deliver
extensions compatible with v10 and v11 in the same version, when
'TYPO3_MODE' constant is deprecated in v11 with upcoming patches.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1011

  1. Christian Kuhn uploaded patch set 1 11/28/20, 16:28

  2. TYPO3com voted on patch set 1 V +1 11/28/20, 16:39 Completed build in 11m 18s on Sat, 28 Nov, 04:39 PM Test Summary: 32394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7671

  3. Benni Mack commented on patch set 1 11/28/20, 16:53

    * Should we add an Important rst? So people know it exists?
  4. Benni Mack voted on patch set 1 V +1 CR +1 11/28/20, 16:53

  5. Christian Kuhn commented on patch set 1 11/28/20, 17:03

    > Patch Set 1: > > * Should we add an Important rst? So people know it exists? We'll have .rst files in v11 when TYPO3_MODE is deprecated. I think it's fair enough to not bother devs in v10 with this: The v10 backport of this change is basically just meant for ext devs who are working on v11 versions of their extensions. Thus, I'd target the .rst files to v11 only and did not include them in this patch.
  6. Christoph Lehmann commented on patch set 1 11/28/20, 17:12

    IMHO the statement 'defined('TYPO3_MODE') or die();' is just a workaround for the problem: Files are unnecessarily. This should be fixed and these statements should be removed completely. How to achieve this? i) Block request to files outside EXT:example/Resources/Public/ via .htaccess (TYPO3.CMS/typo3/sysext/install/Resources/Private/FolderStructureTemplateFiles/root-htaccess) This is currently partially given and could be improved. ii) Implement https://github.com/helhum/typo3-secure-web in core. We use it in every project. The project introduces a new document root "web" (or public) and symlinks all Resources/Public/ folders. Pretty simple and secure. Admitted, it would be breaking too, but things go in the correct direction.
  7. Christoph Lehmann commented on patch set 1 11/28/20, 17:18

    *Files are unnecessarily exposed...
  8. Christian Kuhn commented on patch set 1 11/28/20, 17:22

    Thx Christoph. You're right: Mid-term, we should get rid of ext_* files altogether. There are a couple of strategies to achieve that and the files are getting smaller from version to version already. This needs more effort and is a different thing than phasing out TYPO3_MODE, though. For the time being, we want to phase out TYPO3_MODE and need some substitution. The new constant shouldn't harm and does not collide with anything else.
  9. Anja Leichsenring voted on patch set 1 V +1 CR +1 11/28/20, 17:30

  10. Christian Kuhn voted on patch set 1 V +2 CR +2 11/28/20, 17:34

  11. Christian Kuhn merged patch set 2 11/28/20, 17:36