Review main Merged

66943[TASK] Drop TYPO3_MODE usage in ext:adminpanel ext_localconf.php

Christian Kuhn CR +2 V +2 Easy +11 −6 updated 11/29/20, 15:32

Commit message

Code in ext_localconf.php must not create different
framework state depending on the (frontend or backend)
application type. The ApplicationType helper class does
not work at this point in bootstrap, since the PSR-7
request object has not been created, yet.

Solution is to always register the admin panel logger,
and to decide within the logger instance if an incoming
log record should be handled.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Anja Leichsenring +1
    • Daniel Haupt +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Anja Leichsenring +1
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 3

Files 2

Review log 78

  1. Christian Kuhn uploaded patch set 1 11/29/20, 13:52

  2. Simon Gilli voted on patch set 1 CR +1 11/29/20, 13:55

  3. TYPO3com voted on patch set 1 V +1 11/29/20, 14:04 Completed build in 11m 38s on Sun, 29 Nov, 02:04 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7686

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 11/29/20, 14:11

  5. Daniel Haupt voted on patch set 1 V +1 CR +1 11/29/20, 14:17

  6. Simon Gilli voted on patch set 1 V +1 11/29/20, 14:44

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 11/29/20, 15:32

  8. Christian Kuhn merged patch set 2 11/29/20, 15:32