Review main Merged

66946[BUGFIX] Use configuration context for placeholders in YAML import

Sascha Egerer CR +2 V +2 Easy +26 −1 updated 06/03/22, 18:03

Commit message

The placeholder replacement in the yaml import method must receive
the current configuration context to be able to replace placeholders
with values that are already configured instead of the subvalues of
the import statement.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Daniel Goerz +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1319

  1. Sascha Egerer uploaded patch set 1 11/30/20, 13:17

  2. TYPO3com voted on patch set 1 V +1 11/30/20, 13:28 Completed build in 10m 26s on Mon, 30 Nov, 01:28 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7697

  3. Oli Bartsch updated the commit message in patch set 2 11/30/20, 14:11

  4. TYPO3com voted on patch set 2 V +1 11/30/20, 14:23 Completed build in 11m 25s on Mon, 30 Nov, 02:23 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7703

  5. Mathias Brodala commented on patch set 2 11/30/20, 14:37

    Just to be sure: doesn't this mean placeholders in an imported file cannot refer to the content of the file itself?
  6. Sascha Egerer commented on patch set 2 11/30/20, 18:06

    > Patch Set 2: > > Just to be sure: doesn't this mean placeholders in an imported file cannot refer to the content of the file itself? Well in an imported file the $content will be the content of the imported file but not the "parent" or "already parsed" content. But IMO this is a different feature.
  7. Benni Mack rebased onto patch set 3 11/04/21, 11:28

  8. core-ci voted on patch set 3 V +1 11/04/21, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18869

  9. Benni Mack updated the commit message in patch set 4 11/18/21, 10:44

  10. core-ci voted on patch set 4 V +1 11/18/21, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19459

  11. Benni Mack wrote 11/29/21, 10:18

    Change destination moved from master to main
  12. Benni Mack updated the commit message in patch set 5 11/29/21, 14:07

  13. core-ci voted on patch set 5 V +1 11/29/21, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20093

  14. Susi Moog commented on patch set 5 04/04/22, 15:26

    Can we test this behaviour to make sure it's clear what should be achieved?
  15. Daniel Goerz uploaded patch set 6 06/03/22, 13:54

  16. Daniel Goerz voted on patch set 6 V +1 CR +1 06/03/22, 14:03

  17. core-ci voted on patch set 6 V +1 06/03/22, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27680

  18. Oli Bartsch voted on patch set 6 V +2 CR +2 06/03/22, 18:03

  19. Oli Bartsch merged patch set 7 06/03/22, 18:03