66947[BUGFIX] Avoid exception when trying to download a non-existing file
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Daniel Goerz +1
-
Verified V +2 Done
- Oliver Hader +2
- Daniel Goerz +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1620
-
Stephan Großberndt uploaded patch set 1 11/30/20, 13:41
-
Markus Klein commented on patch set 1 11/30/20, 13:48
-
TYPO3com voted on patch set 1 V +1 11/30/20, 13:54 Completed build in 12m 19s on Mon, 30 Nov, 01:54 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7698
-
Stephan Großberndt uploaded patch set 2 11/30/20, 13:56
-
Markus Klein voted on patch set 2 V +1 CR +1 11/30/20, 14:03
-
Stephan Großberndt uploaded patch set 3 11/30/20, 14:05
-
Stephan Großberndt wrote 11/30/20, 14:07
Description of patch set 3 set to "Applied fix for $parameters['r'] and $parameters['p'] too" -
Stephan Großberndt wrote 11/30/20, 14:08
Description of patch set 2 set to "Changed code to a single condition as proposed by Markus" -
TYPO3com voted on patch set 2 V -1 11/30/20, 14:12 Completed build in 15m 28s on Mon, 30 Nov, 02:12 PM Test Summary: 2 of 32645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7701
-
TYPO3com voted on patch set 3 V +1 11/30/20, 14:16 Completed build in 11m 30s on Mon, 30 Nov, 02:16 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7702
-
Oliver Klee commented on patch set 3 11/30/20, 14:22
Can we have a regression test for this? -
Stephan Großberndt commented on patch set 3 11/30/20, 14:24
Yes, that would be great, please add one! -
Oliver Hader voted on patch set 3 CR +1 12/03/20, 11:06
-
Daniel Goerz uploaded patch set 4 04/27/21, 21:14
-
Daniel Goerz voted on patch set 4 V +1 CR +1 04/27/21, 21:15
-
Daniel Goerz commented on patch set 4 04/27/21, 21:19
Sorry, I did not see this patch when https://review.typo3.org/c/Packages/TYPO3.CMS/+/68887/ was merged -
core-ci voted on patch set 4 V +1 04/27/21, 21:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10794
-
Oliver Hader voted on patch set 4 V +2 CR +2 04/27/21, 21:37
-
Oliver Hader merged patch set 5 04/27/21, 21:42
-
Stephan Großberndt commented on patch set 5 10/11/21, 09:44
FileDumpController.php:177ReplyDone
FileDumpController.php:177