Review main Merged

66947[BUGFIX] Avoid exception when trying to download a non-existing file

Stephan Großberndt CR +2 V +2 Easy +3 −11 updated 10/11/21, 09:44

Commit message

This patch fixes a regression introduced by change
https://review.typo3.org/c/Packages/TYPO3.CMS/+/65126 which lead to
an HTTP 500 exception instead of returning HTTP 404 by making sure
that FileDumpController->isFileValid() is not called with NULL as
parameter.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Daniel Goerz +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1620

  1. Stephan Großberndt uploaded patch set 1 11/30/20, 13:41

  2. Markus Klein commented on patch set 1 11/30/20, 13:48

    FileDumpController.php:177

    simply add this to the first condition? if ($file->isDeleted() || $file->isMissing() || !$this->isFileValid($file))
  3. TYPO3com voted on patch set 1 V +1 11/30/20, 13:54 Completed build in 12m 19s on Mon, 30 Nov, 01:54 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7698

  4. Stephan Großberndt uploaded patch set 2 11/30/20, 13:56

  5. Markus Klein voted on patch set 2 V +1 CR +1 11/30/20, 14:03

  6. Stephan Großberndt uploaded patch set 3 11/30/20, 14:05

  7. Stephan Großberndt wrote 11/30/20, 14:07

    Description of patch set 3 set to "Applied fix for $parameters['r'] and $parameters['p'] too"
  8. Stephan Großberndt wrote 11/30/20, 14:08

    Description of patch set 2 set to "Changed code to a single condition as proposed by Markus"
  9. TYPO3com voted on patch set 2 V -1 11/30/20, 14:12 Completed build in 15m 28s on Mon, 30 Nov, 02:12 PM Test Summary: 2 of 32645 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7701

  10. TYPO3com voted on patch set 3 V +1 11/30/20, 14:16 Completed build in 11m 30s on Mon, 30 Nov, 02:16 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7702

  11. Oliver Klee commented on patch set 3 11/30/20, 14:22

    Can we have a regression test for this?
  12. Stephan Großberndt commented on patch set 3 11/30/20, 14:24

    Yes, that would be great, please add one!
  13. Oliver Hader voted on patch set 3 CR +1 12/03/20, 11:06

  14. Daniel Goerz uploaded patch set 4 04/27/21, 21:14

  15. Daniel Goerz voted on patch set 4 V +1 CR +1 04/27/21, 21:15

  16. Daniel Goerz commented on patch set 4 04/27/21, 21:19

    Sorry, I did not see this patch when https://review.typo3.org/c/Packages/TYPO3.CMS/+/68887/ was merged
  17. core-ci voted on patch set 4 V +1 04/27/21, 21:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10794

  18. Oliver Hader voted on patch set 4 V +2 CR +2 04/27/21, 21:37

  19. Oliver Hader merged patch set 5 04/27/21, 21:42

  20. Stephan Großberndt commented on patch set 5 10/11/21, 09:44

    FileDumpController.php:177 Reply

    Done