66949[BUGFIX] Ignore unmapped tables on non-default connections
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2333
Show 58 earlier messages
-
Stephan Großberndt uploaded patch set 1 11/30/20, 17:37
-
TYPO3com voted on patch set 1 V -1 11/30/20, 17:38 Completed build in 34s on Mon, 30 Nov, 05:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7713
-
Stephan Großberndt uploaded patch set 2 11/30/20, 17:45
-
TYPO3com commented on patch set 2 11/30/20, 17:45 Completed build in 27s on Mon, 30 Nov, 05:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7714
-
Stephan Großberndt uploaded patch set 3 11/30/20, 17:45
-
TYPO3com voted on patch set 3 V -1 11/30/20, 17:58 Completed build in 12m 17s on Mon, 30 Nov, 05:58 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7715
-
Stephan Großberndt uploaded patch set 4 11/30/20, 18:40
-
Stephan Großberndt wrote 11/30/20, 18:41
Description of patch set 4 set to "make phpstan happy by always defining $tablesForConnection"
-
Stephan Großberndt wrote 11/30/20, 18:42
Description of patch set 3 set to "fix cgl and add comment" -
TYPO3com voted on patch set 4 V +1 11/30/20, 18:53 Completed build in 12m 23s on Mon, 30 Nov, 06:53 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7718
-
Benni Mack uploaded patch set 5 11/04/21, 11:28
-
core-ci voted on patch set 5 V +1 11/04/21, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18868
-
Benni Mack commented on patch set 5 CR +1 11/10/21, 20:06
Look okay, but how can I test this? -
Christian Kuhn commented on patch set 5 11/10/21, 21:27
General note on this: I think the current system of allowing any table to be mapped to a different db connection does not work out: This gives basically unsolvable issues as soon as you want to join something, for instance. I had a chat with Helmut on that a couple of weeks ago, and we think we should drop that feature for the "main set of core tables" in v12. There are some dedicated things that can be useful, though: For instance it would be nice to allow having for instance a single cache using a different dmbs (which is for instance ram driven for increased speed of the pages cache ...). But that would be a feature on cache level (and *maybe* a similar solution for session tables). That would change the api: *some* dedicated things are allowed with different connections, but the main table set needs to be located in one database. Everything else does not make much sense ... This is a v12 topic to see how / what in the API should be changed and maybe simplified. -
Stephan Großberndt commented on patch set 5 11/10/21, 21:54
I ran into the issue with a TYPO3 installation using data from another database. I added a table mapping for the single view I needed to access from the other database. This lead to errors because all tables were scanned and unmapped tables from the other database contained (geo) data types Doctrine did not know. so have another database with two tables, add a mapping for one and the other tables datatypes should not matter. -
Christian Kuhn commented on patch set 5 11/10/21, 22:21
Reply
I'd be interested in your use case to see how this related to my ideas on streamlining the api in v12, let's chat on this when time is right. This patch can and should be done nevertheless of course and i'll give it a review soon. -
Benni Mack updated the commit message in patch set 6 11/18/21, 10:46
-
core-ci voted on patch set 6 V +1 11/18/21, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19468
-
Benni Mack wrote 11/28/21, 22:09
Removed reviewer Benni Mack. -
Benni Mack wrote 11/29/21, 10:22
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 7 11/29/21, 14:12
-
core-ci voted on patch set 7 V +1 11/29/21, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20126
-
Benni Mack uploaded patch set 8 12/18/21, 08:00
-
core-ci voted on patch set 8 V +1 12/18/21, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21230
-
Christian Kuhn rebased onto patch set 9 12/21/21, 16:07
-
core-ci voted on patch set 9 V +1 12/21/21, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21362
-
Stefan Bürk voted on patch set 9 V +1 CR +1 12/21/21, 16:40
-
Stefan Bürk uploaded patch set 10 12/21/21, 16:53
-
Stefan Bürk voted on patch set 10 V +1 CR +1 12/21/21, 16:54
-
Christian Kuhn voted on patch set 10 V +1 CR +1 12/21/21, 16:58
-
core-ci voted on patch set 10 V +1 12/21/21, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21371
-
Christian Kuhn voted on patch set 10 V +2 CR +2 12/21/21, 17:10
-
Christian Kuhn merged patch set 11 12/21/21, 17:10