Review 10.4 Merged

66951[BUGFIX] Fix PHP warning on second call to reset password link

Stephan Großberndt CR +2 V +2 Easy +4 −2 updated 01/06/21, 13:44

Commit message

This patch fixes a PHP warning being logged to sys_log when clicking
the reset password link again after the password has been changed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2131

Show 46 earlier messages
  1. Stephan Großberndt uploaded patch set 1 11/30/20, 18:36

  2. TYPO3com voted on patch set 1 V -1 11/30/20, 18:36 Completed build in 33s on Mon, 30 Nov, 06:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-850

  3. Stephan Großberndt uploaded patch set 2 11/30/20, 18:37

  4. TYPO3com voted on patch set 2 V -1 11/30/20, 18:49 Completed build in 12m 04s on Mon, 30 Nov, 06:49 PM Test Summary: 75213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-851

  5. Oliver Klee commented on patch set 2 CR -1 11/30/20, 19:24

    FrontendLoginController.php:364

    Now $hashEquals might be undefined, but it will be used in line 368. We need to define it in all cases.
  6. Stephan Großberndt rebased onto patch set 3 12/03/20, 20:05

  1. Stephan Großberndt uploaded patch set 4 12/03/20, 20:06

  2. Stephan Großberndt commented on patch set 4 12/03/20, 20:07

    FrontendLoginController.php:364 Reply

    Done
  3. TYPO3com voted on patch set 4 V -1 12/03/20, 20:08 Completed build in 22s on Thu, 3 Dec, 08:08 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-866

  4. Stephan Großberndt uploaded patch set 5 12/03/20, 20:09

  5. TYPO3com voted on patch set 5 V -1 12/03/20, 20:10 Completed build in 27s on Thu, 3 Dec, 08:10 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-867

  6. Stephan Großberndt wrote 12/03/20, 20:11

    Description of patch set 5 set to "moved other comparehash checks to first if check for easier readability and to avoid unnecessary checks"
  7. Stephan Großberndt wrote 12/03/20, 20:11

    Description of patch set 4 set to "fixed undefined notice"
  8. Stephan Großberndt wrote 12/03/20, 20:11

    Description of patch set 3 set to "rebase"
  9. Stephan Großberndt wrote 12/03/20, 20:12

    Description of patch set 2 set to "fixed cgl issue"
  10. Stephan Großberndt uploaded patch set 6 12/03/20, 20:13

  11. Stephan Großberndt wrote 12/03/20, 20:14

    Description of patch set 6 set to "fixed cgl"
  12. Oliver Klee wrote 12/03/20, 20:15

    Removed reviewer Oliver Klee.
  13. TYPO3com voted on patch set 3 V -1 12/03/20, 20:17 Completed build in 11m 31s on Thu, 3 Dec, 08:17 PM Test Summary: 75213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-865

  14. TYPO3com voted on patch set 6 V +1 12/03/20, 20:24 Completed build in 11m 37s on Thu, 3 Dec, 08:24 PM Test Summary: 75213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-868

  15. TYPO3com commented on patch set 6 12/03/20, 22:26 Completed build in 11m 53s on Thu, 3 Dec, 10:26 PM Test Summary: 75213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-869

  16. TYPO3com commented on patch set 6 12/03/20, 23:21 Completed build in 11m 39s on Thu, 3 Dec, 11:21 PM Test Summary: 75213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-870

  17. Benni Mack voted on patch set 6 CR +1 01/05/21, 13:54

  18. Christian Kuhn updated the commit message in patch set 7 01/06/21, 12:53

  19. Christian Kuhn commented on patch set 7 V +1 CR +1 01/06/21, 12:54

    i thought about not accepting 9.5, but since it's a crash it's fine with me.
  20. Christian Kuhn commented on patch set 7 01/06/21, 12:54

    note: master not affected since this is the pibase based felogin, which has been removed in master.
  21. TYPO3com voted on patch set 7 V -1 01/06/21, 13:08 Completed build in 14m 24s on Wed, 6 Jan, 01:08 PM Test Summary: 74589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-965

  22. TYPO3com voted on patch set 7 V +1 01/06/21, 13:22 Completed build in 43m 11s on Wed, 6 Jan, 01:22 PM Test Summary: 75280 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-965

  23. Oli Bartsch voted on patch set 7 V +1 CR +1 01/06/21, 13:43

  24. Christian Kuhn voted on patch set 7 V +2 CR +2 01/06/21, 13:44

  25. Christian Kuhn merged patch set 8 01/06/21, 13:44