Review main Merged

66952[TASK] Use default from address in scheduler's test task

Georg Ringer CR +2 V +2 Easy +4 −1 updated 12/01/20, 14:10

Commit message

Change the from address used in the test task of the scheduler 
by using the default address configured in
`$GLOBALS['TYPO3_CONF_VARS']['MAIL']['defaultMailFromAddress']`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Froemken +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Georg Ringer uploaded patch set 1 11/30/20, 18:58

  2. Georg Ringer commented on patch set 1 11/30/20, 18:59

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 11/30/20, 19:10 Completed build in 11m 11s on Mon, 30 Nov, 07:10 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7719

  4. Stefan Froemken commented on patch set 1 11/30/20, 20:12

    TestTask.php:68

    I would prefer using the elvis operator here
  5. Josef Glatz updated the commit message in patch set 2 11/30/20, 20:17

  6. TYPO3com voted on patch set 2 V +1 11/30/20, 20:28 Completed build in 10m 55s on Mon, 30 Nov, 08:28 PM Test Summary: 32402 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7721

  7. Oli Bartsch commented on patch set 2 11/30/20, 22:44

    TestTask.php:68 Reply

    This would lead to an undefined index notice if `['defaultMailFromAddress']` does not exist. In PHP 8.0 this will even be a "Undefined array key" warning.
  8. Stefan Froemken commented on patch set 2 V +1 CR +1 12/01/20, 13:59

    TestTask.php:68 Reply Unresolved

    Damn...what a broken programming language. Ok +1 for this ticket, but -2 for PHP. NARF.
  9. Oli Bartsch voted on patch set 2 V +1 CR +1 12/01/20, 14:08

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 12/01/20, 14:09

  11. Christian Kuhn merged patch set 3 12/01/20, 14:10