66952[TASK] Use default from address in scheduler's test task
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Froemken +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Froemken +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 911
-
Georg Ringer uploaded patch set 1 11/30/20, 18:58
-
Georg Ringer commented on patch set 1 11/30/20, 18:59
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 11/30/20, 19:10 Completed build in 11m 11s on Mon, 30 Nov, 07:10 PM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7719
-
Stefan Froemken commented on patch set 1 11/30/20, 20:12
TestTask.php:68I would prefer using the elvis operator here -
Josef Glatz updated the commit message in patch set 2 11/30/20, 20:17
-
TYPO3com voted on patch set 2 V +1 11/30/20, 20:28 Completed build in 10m 55s on Mon, 30 Nov, 08:28 PM Test Summary: 32402 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7721
-
Oli Bartsch commented on patch set 2 11/30/20, 22:44
TestTask.php:68ReplyThis would lead to an undefined index notice if `['defaultMailFromAddress']` does not exist. In PHP 8.0 this will even be a "Undefined array key" warning. -
Stefan Froemken commented on patch set 2 V +1 CR +1 12/01/20, 13:59
TestTask.php:68Reply UnresolvedDamn...what a broken programming language. Ok +1 for this ticket, but -2 for PHP. NARF. -
Oli Bartsch voted on patch set 2 V +1 CR +1 12/01/20, 14:08
-
Christian Kuhn voted on patch set 2 V +2 CR +2 12/01/20, 14:09
-
Christian Kuhn merged patch set 3 12/01/20, 14:10