Review main Merged

66955[BUGFIX] Extend condition for isOnSymmetricSide

Tim Karliczek CR +2 V +2 Easy +33 −1 updated 11/03/21, 19:02

Commit message

Instead of holding only the uid as a plain value the given databaseRow
array of the symmetric_field can hold an array containing a lot of
information about the related foreign record.
This e.g. applies if type group is used instead of type select.
Now isOnSymmetricSide is set to true in both cases.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Tim Karliczek uploaded patch set 1 12/01/20, 08:27

  2. TYPO3com voted on patch set 1 V +1 12/01/20, 08:39 Completed build in 12m 17s on Tue, 1 Dec, 08:39 AM Test Summary: 32406 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7723

  3. Tim Karliczek uploaded patch set 2 12/01/20, 17:41

  4. TYPO3com voted on patch set 2 V +1 12/01/20, 17:50 Completed build in 09m 17s on Tue, 1 Dec, 05:50 PM Test Summary: 32407 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7737

  5. Christian Kuhn uploaded patch set 3 11/03/21, 17:29

  6. core-ci voted on patch set 3 V +1 11/03/21, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18806

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 11/03/21, 19:00

  8. Christian Kuhn commented on patch set 3 11/03/21, 19:01

    ... sorry for the delay ...
  9. Anja Leichsenring voted on patch set 3 V +1 CR +1 11/03/21, 19:01

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 11/03/21, 19:02

  11. Christian Kuhn merged patch set 4 11/03/21, 19:02