Review main Abandoned

66963[TASK] Deprecate constant TYPO3_mainDir

Christian Kuhn CR 0 V 0 Normal +53 −13 updated 12/09/20, 13:27

Commit message

TYPO3_mainDir is always defined to 'typo3/'. This
last global constant is not really required and
the naming is odd.

Usages can be easily substituted. The patch does this
and marks the the constant as deprecated.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 15

Review log 45

  1. Christian Kuhn uploaded patch set 1 12/02/20, 11:40

  2. TYPO3com voted on patch set 1 V +1 12/02/20, 11:50 Completed build in 09m 43s on Wed, 2 Dec, 11:50 AM Test Summary: 32405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7745

  3. Christian Kuhn commented on patch set 1 CR -1 12/02/20, 11:56

    -1 for the time being. maybe we'll change this a bit or postpone the change.
  4. Christian Kuhn commented on patch set 1 12/09/20, 13:27

    abandoned for now: we may do that later, though.
  5. Christian Kuhn abandoned the change 12/09/20, 13:27