Review main Merged

66966[BUGFIX] Fix dispatching of `formengine.dp.change` event for date fields

Andreas Kienast CR +2 V +2 Easy +13 −10 updated 12/03/20, 17:58

Commit message

With the introduction of a new datetime picker, the listener for the
event `formengine.dp.change` was not attached properly which broke the
validation of updated datetime field. The listener is now attached to
the datetimer field properly.

To avoid introducing jQuery again, the method
`FormEngineValidation.markFieldAsChanged` became aware of non-jQuery
objects.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 45

  1. Andreas Kienast uploaded patch set 1 12/03/20, 08:48

  2. TYPO3com voted on patch set 1 V +1 12/03/20, 09:48 Completed build in 10m 38s on Thu, 3 Dec, 09:48 AM Test Summary: 32405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7749

  3. Markus Klein voted on patch set 1 V +1 CR +1 12/03/20, 10:54

  4. Georg Ringer voted on patch set 1 V +2 CR +2 12/03/20, 17:58

  5. Georg Ringer merged patch set 2 12/03/20, 17:58