Review main Merged Breaking

66968[!!!][TASK] Do not handle deleted records in reference index

Christian Kuhn CR +2 V +2 Impossible +11518 −11707 updated 12/08/20, 21:54

Commit message

Keeping relation information for soft deleted records
in sys_refindex is quite useless: When records are
undeleted, the reference index is updated to recreate
rows. Additionally, the deleted handling was incomplete,
especially if a record on the 'right' side of the relation
got deleted.

The patch drops the deleted field from the table and
prevents adding relations for soft deleted rows.
Furthermore, visibility of a couple of properties and
methods is changed to protected and a series of not used
methods is removed.

Note the hash sums change due to the removal of the deleted
field. The CLI command "bin/typo3 referenceindex:update"
will update hashes and will drop obsolete deleted rows.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 860

Show 840 more files

Review log 1830

Show 35 earlier messages
  1. Christian Kuhn uploaded patch set 1 12/03/20, 09:54

  2. TYPO3com voted on patch set 1 V -1 12/03/20, 10:06 Completed build in 11m 09s on Thu, 3 Dec, 10:06 AM Test Summary: 153 of 32646 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7752

  3. Christian Kuhn uploaded patch set 2 12/03/20, 10:27

  4. TYPO3com voted on patch set 2 V +1 12/03/20, 10:38 Completed build in 11m 22s on Thu, 3 Dec, 10:38 AM Test Summary: 32405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7753

  5. Christian Kuhn uploaded patch set 3 12/03/20, 10:49

  1. TYPO3com voted on patch set 3 V +1 12/03/20, 10:59 Completed build in 09m 17s on Thu, 3 Dec, 10:59 AM Test Summary: 32405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7755

  2. Christian Kuhn commented on patch set 3 CR -1 12/03/20, 13:04

    ReferenceIndex.php:1220

    That's actually a bad idea: This can prevent that records refindexes are properly updated when a record has just been deleted.
  3. Christian Kuhn uploaded patch set 4 12/03/20, 13:25

  4. TYPO3com voted on patch set 4 V +1 12/03/20, 13:34 Completed build in 09m 34s on Thu, 3 Dec, 01:34 PM Test Summary: 32405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7757

  5. Christian Kuhn uploaded patch set 5 12/07/20, 17:06

  6. TYPO3com voted on patch set 5 V -1 12/07/20, 17:24 Completed build in 11m 10s on Mon, 7 Dec, 05:24 PM Test Summary: 243 of 32652 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7929

  7. Christian Kuhn uploaded patch set 6 12/07/20, 17:34

  8. TYPO3com voted on patch set 6 V -1 12/07/20, 17:44 Completed build in 09m 22s on Mon, 7 Dec, 05:44 PM Test Summary: 147 of 32652 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7930

  9. Christian Kuhn uploaded patch set 7 12/07/20, 17:52

  10. TYPO3com voted on patch set 7 V -1 12/07/20, 18:02 Completed build in 09m 12s on Mon, 7 Dec, 06:02 PM Test Summary: 6 of 32652 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7933

  11. Christian Kuhn uploaded patch set 8 12/07/20, 18:24

  12. TYPO3com voted on patch set 8 V -1 12/07/20, 18:33 Completed build in 09m 30s on Mon, 7 Dec, 06:33 PM Test Summary: 3 of 32652 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7936

  13. Christian Kuhn uploaded patch set 9 12/08/20, 12:41

  14. Christian Kuhn commented on patch set 9 12/08/20, 12:51

    ReferenceIndex.php:1220 Reply

    Done
  15. TYPO3com voted on patch set 9 V +1 12/08/20, 12:54 Completed build in 13m 04s on Tue, 8 Dec, 12:54 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7960

  16. Christian Kuhn uploaded patch set 10 12/08/20, 14:42

  17. TYPO3com voted on patch set 10 V -1 12/08/20, 14:51 Completed build in 08m 44s on Tue, 8 Dec, 02:51 PM Test Summary: 11 of 32652 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7965

  18. TYPO3com voted on patch set 10 V +1 12/08/20, 15:58 Completed build in 1h 24m 19s on Tue, 8 Dec, 03:58 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7965

  19. Benni Mack voted on patch set 10 V +1 CR +1 12/08/20, 16:12

  20. Christian Kuhn commented on patch set 10 CR -1 12/08/20, 17:15

    [!!!] misses in commit msg.
  21. Oli Bartsch uploaded patch set 11 12/08/20, 17:37

  22. Oli Bartsch voted on patch set 11 V +1 CR +1 12/08/20, 17:38

  23. TYPO3com voted on patch set 11 V +1 12/08/20, 17:48 Completed build in 10m 01s on Tue, 8 Dec, 05:48 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7970

  24. Benni Mack voted on patch set 11 V +2 CR +2 12/08/20, 21:54

  25. Benni Mack merged patch set 12 12/08/20, 21:54