Review main Merged

66971[TASK] Require doctrine/dbal 2.12.0

Benni Mack CR +2 V +2 Normal +33 −18 updated 12/04/20, 06:08

Commit message

This is a pre-cursor for PHP 8.0 support
as well as a preliminary change to ensure
a smooth upgrade path to doctrine/dbal 3.0

Used composer command

* composer req "doctrine/dbal:^2.12"

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Haupt +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Haupt +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 56

  1. Benni Mack uploaded patch set 1 12/03/20, 15:36

  2. TYPO3com voted on patch set 1 V +1 12/03/20, 15:46 Completed build in 10m 09s on Thu, 3 Dec, 03:46 PM Test Summary: 32405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7763

  3. Georg Ringer voted on patch set 1 V +1 CR +1 12/03/20, 17:57

  4. Daniel Haupt voted on patch set 1 V +1 CR +1 12/04/20, 01:21

  5. Benni Mack voted on patch set 1 V +2 CR +2 12/04/20, 06:08

  6. Benni Mack merged patch set 2 12/04/20, 06:08