Review main Abandoned

66993[BUGFIX] Treat RedirectFinisher target as potential integer

Andreas Kienast CR 0 V 0 Easy +7 −2 updated 12/04/20, 13:53

Commit message

With #92112 EXT:form was "phpstanified" which changed the behavior of
the `pageUid` option as it was not possible anymore to supply an integer
value, altough this is explicitly documented. This patch now
additionally checks whether the value is not an integer.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 12/04/20, 09:23

  2. TYPO3com voted on patch set 1 V +1 12/04/20, 09:33 Completed build in 10m 18s on Fri, 4 Dec, 09:33 AM Test Summary: 32405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7774

  3. Oliver Klee voted on patch set 1 CR +1 12/04/20, 10:11

  4. Alexander Schnitzler commented on patch set 1 12/04/20, 11:09

    RedirectFinisher.php:72 Unresolved

    Isn't it as easy as > $pageUid = $this->parseOption('pageUid'); > $pageUid = is_string($pageUid) ? (int)str_replace('pages_', '', $pageUid) : (int)$pageUid; or > $pageUid = (string)$this->parseOption('pageUid'); > $pageUid = (int)str_replace('pages_', '', $pageUid); ?
  5. Elias Häußler commented on patch set 1 12/04/20, 11:34

    There's already a pending patch which handles this: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66620
  6. Andreas Kienast abandoned the change 12/04/20, 13:53