Review main Merged

66997[TASK] Remove browser-native Notification API

Benni Mack CR +2 V +2 Normal +4 −57 updated 12/04/20, 17:59

Commit message

TYPO3 has native Browser Notification API since a few TYPO3 versions.

However, also due to recent security implementations (permission API)
in browsers, and TYPO3 not strongly using this feature (only for LoginRefresh
when a login is about to expire, and ONLY when this window is not focussed),
this feature is dropped in favor of UX.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 69

  1. Benni Mack uploaded patch set 1 12/04/20, 15:22

  2. TYPO3com voted on patch set 1 V +1 12/04/20, 15:31 Completed build in 09m 14s on Fri, 4 Dec, 03:31 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7789

  3. Andreas Kienast uploaded patch set 2 12/04/20, 16:25

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 12/04/20, 16:26

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 12/04/20, 16:27

  6. TYPO3com voted on patch set 2 V -1 12/04/20, 16:36 Completed build in 10m 56s on Fri, 4 Dec, 04:36 PM Test Summary: 1 of 32656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7796

  7. TYPO3com voted on patch set 2 V +1 12/04/20, 16:54 Completed build in 39m 42s on Fri, 4 Dec, 04:54 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7796

  8. Georg Ringer voted on patch set 2 V +2 CR +2 12/04/20, 17:59

  9. Georg Ringer merged patch set 3 12/04/20, 17:59