Review main Merged Breaking

67000[!!!][TASK] Remove TypoScript option addQueryString.method

Benni Mack CR +2 V +2 Hard +131 −302 updated 12/10/20, 07:25

Commit message

The option typolink.addQueryString.method only has either "GET"
or nothing (using $_SERVER[QUERY_PARAMS]) as possibility.

In order to effectively make use of PSR-7 Requests and better
routing capabilities, the "GET" method is preferred, making
the whole option obsolete, and removing it.

All related Fluid arguments and Extbase UriBuilder
methods are deprecated.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 23

Show 3 more files

Review log 1222

  1. Benni Mack uploaded patch set 1 12/04/20, 16:08

  2. Oliver Hader commented on patch set 1 CR +1 12/04/20, 16:15

    👌 😎
  3. TYPO3com voted on patch set 1 V -1 12/04/20, 16:24 Completed build in 12m 22s on Fri, 4 Dec, 04:24 PM Test Summary: 8 of 32656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7794

  4. Benni Mack uploaded patch set 2 12/07/20, 14:50

  5. TYPO3com voted on patch set 2 V -1 12/07/20, 15:12 Completed build in 15m 23s on Mon, 7 Dec, 03:12 PM Test Summary: 10 of 32650 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7919

  6. Oli Bartsch uploaded patch set 3 12/09/20, 15:27

  7. TYPO3com voted on patch set 3 V +1 12/09/20, 15:38 Completed build in 11m 31s on Wed, 9 Dec, 03:38 PM Test Summary: 32397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8004

  8. Oli Bartsch uploaded patch set 4 12/09/20, 17:10

  9. TYPO3com voted on patch set 4 V -1 12/09/20, 17:11 Completed build in 19s on Wed, 9 Dec, 05:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8005

  10. Oli Bartsch uploaded patch set 5 12/09/20, 17:13

  11. TYPO3com voted on patch set 5 V -1 12/09/20, 17:24 Completed build in 11m 01s on Wed, 9 Dec, 05:24 PM Test Summary: 2 of 29935 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8006

  12. TYPO3com commented on patch set 5 12/09/20, 18:18 Completed build in 10m 50s on Wed, 9 Dec, 06:18 PM Test Summary: 31706 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8007

  13. Benni Mack uploaded patch set 6 12/09/20, 20:23

  14. TYPO3com voted on patch set 6 V -1 12/09/20, 20:34 Completed build in 10m 39s on Wed, 9 Dec, 08:34 PM Test Summary: 31344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8009

  15. TYPO3com voted on patch set 6 V +1 12/09/20, 20:50 Completed build in 37m 00s on Wed, 9 Dec, 08:50 PM Test Summary: 32399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8009

  16. Benni Mack commented on patch set 7 12/09/20, 21:28

    Published edit on patch set 6.
  17. TYPO3com voted on patch set 7 V -1 12/09/20, 21:41 Completed build in 12m 13s on Wed, 9 Dec, 09:41 PM Test Summary: 32039 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8012

  18. Oliver Hader voted on patch set 7 CR +1 12/09/20, 22:09

  19. TYPO3com voted on patch set 7 V +1 12/09/20, 22:14 Completed build in 57m 43s on Wed, 9 Dec, 10:14 PM Test Summary: 32399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8012

  20. Georg Ringer voted on patch set 7 V +1 CR +1 12/10/20, 07:21

  21. Benni Mack voted on patch set 7 V +2 CR +2 12/10/20, 07:25

  22. Benni Mack merged patch set 8 12/10/20, 07:25