Review main Merged Breaking

67001[!!!][TASK] Set no-cache headers only to PSR-7 Response

Benni Mack CR +2 V +2 Normal +73 −49 updated 12/05/20, 21:36

Commit message

The related HTTP no-cache headers (e.g. when a user is logged in)
are now only set via PSR-15 middlewares (already in place for
Backend Users, but now added for Frontend Users / Sessions as well),
but not directly emitted via "header()" functions anymore.

The next steps for having autonomous tests are:
* Do not send cookies directly anymore
* Double-check backend login cookies and
* Check for ImmediateResponse / HttpUtility::redirect() methods
* Evaluate the HTTP headers emitted inside the Installer.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 712

  1. Benni Mack uploaded patch set 1 12/04/20, 16:14

  2. TYPO3com voted on patch set 1 V -1 12/04/20, 16:29 Completed build in 10m 53s on Fri, 4 Dec, 04:29 PM Test Summary: 2 of 32656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7795

  3. Benni Mack uploaded patch set 2 12/04/20, 19:51

  4. TYPO3com voted on patch set 2 V -1 12/04/20, 20:03 Completed build in 12m 00s on Fri, 4 Dec, 08:03 PM Test Summary: 31321 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7809

  5. TYPO3com voted on patch set 2 V +1 12/04/20, 20:14 Completed build in 34m 28s on Fri, 4 Dec, 08:14 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7809

  6. Benni Mack uploaded patch set 3 12/05/20, 19:31

  7. TYPO3com voted on patch set 3 V -1 12/05/20, 19:41 Completed build in 10m 11s on Sat, 5 Dec, 07:41 PM Test Summary: 7 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7835

  8. TYPO3com voted on patch set 3 V +1 12/05/20, 20:19 Completed build in 58m 44s on Sat, 5 Dec, 08:19 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7835

  9. Georg Ringer voted on patch set 3 V +1 CR +1 12/05/20, 21:06

  10. Markus Klein voted on patch set 3 V +1 CR +1 12/05/20, 21:36

  11. Benni Mack voted on patch set 3 V +2 CR +2 12/05/20, 21:36

  12. Benni Mack merged patch set 4 12/05/20, 21:36