Review main Merged Breaking

67002[!!!][TASK] Remove AbstractUserAuthentication->svConfig

Benni Mack CR +2 V +2 Normal +64 −15 updated 12/04/20, 17:27

Commit message

The public property svConfig is just a short-hand variable
for $GLOBALS['TYPO3_CONF_VARS']['SVCONF']['auth'],
but should not be accessed from the outside, and is therefore
moved from a public property to a local variable within the
"checkAuthentication" method where it is mainly used.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 710

  1. Benni Mack uploaded patch set 1 12/04/20, 16:27

  2. TYPO3com voted on patch set 1 V -1 12/04/20, 16:40 Completed build in 12m 00s on Fri, 4 Dec, 04:40 PM Test Summary: 1360 of 32656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7797

  3. Benni Mack uploaded patch set 2 12/04/20, 16:58

  4. Benni Mack uploaded patch set 3 12/04/20, 17:01

  5. TYPO3com voted on patch set 2 V +1 12/04/20, 17:08 Completed build in 10m 02s on Fri, 4 Dec, 05:08 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7804

  6. Andreas Kienast voted on patch set 3 V +1 CR +1 12/04/20, 17:11

  7. TYPO3com voted on patch set 3 V +1 12/04/20, 17:16 Completed build in 10m 15s on Fri, 4 Dec, 05:16 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7805

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 12/04/20, 17:22

  9. Andreas Kienast voted on patch set 3 V +2 CR +2 12/04/20, 17:26

  10. Andreas Kienast merged patch set 4 12/04/20, 17:27