Review main Merged

67005[TASK] Deprecate Hook t3lib/class.t3lib_parsehtml_proc.php:transformation

Lina Wolf CR +2 V +2 Normal +51 −0 updated 04/27/21, 20:09

Commit message

Deprecates both Hooks and adds the fact to the changelog.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1523

  1. Lina Wolf uploaded patch set 1 12/04/20, 21:19

  2. TYPO3com voted on patch set 1 V +1 12/04/20, 21:31 Completed build in 10m 28s on Fri, 4 Dec, 09:31 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7812

  3. Simon Gilli commented on patch set 1 CR -1 12/04/20, 21:37

    RteHtmlParser.php:227 Unresolved

    Please also deprecate this part which is the opposite of the one above.
  4. Lina Wolf uploaded patch set 2 12/04/20, 21:40

  5. Simon Gilli commented on patch set 2 12/04/20, 21:42

    Deprecation-92992-DeprecatedHookT3libclasst3lib_parsehtml_procphptransformationInRteHtmlParser.rst:12 Unresolved

  6. TYPO3com voted on patch set 2 V +1 12/04/20, 21:50 Completed build in 09m 54s on Fri, 4 Dec, 09:50 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7813

  7. Lina Wolf uploaded patch set 3 12/04/20, 21:52

  8. TYPO3com voted on patch set 3 V +1 12/04/20, 22:02 Completed build in 10m 03s on Fri, 4 Dec, 10:02 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7814

  9. Simon Gilli voted on patch set 3 V +1 CR +1 12/05/20, 10:35

  10. Christian Kuhn rebased onto patch set 4 03/26/21, 17:55

  11. Christian Kuhn voted on patch set 4 CR +1 03/26/21, 17:55

  12. TYPO3com voted on patch set 4 V +1 03/26/21, 18:02 Completed build in 07m 19s on Fri, 26 Mar, 06:02 PM Test Summary: 33256 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10372

  13. core-ci voted on patch set 4 V +1 03/26/21, 18:06 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1869

  14. Anja Leichsenring uploaded patch set 5 04/06/21, 16:13

  15. Anja Leichsenring commented on patch set 5 CR -1 04/06/21, 16:14

    Deprecation-92992-HookT3libclasst3lib_parsehtml_procphptransformation.rst:41 Unresolved

    I could not find any extensionScanner entries for the hooks, and the patch does not add any. So what is the FullyScanned flag telling about?
  16. TYPO3com voted on patch set 5 V +1 04/06/21, 16:20 Completed build in 07m 09s on Tue, 6 Apr, 04:20 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10503

  17. core-ci voted on patch set 5 V +1 04/06/21, 16:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2052

  18. Anja Leichsenring commented on patch set 6 04/27/21, 19:44

    Published edit on patch set 5.
  19. Anja Leichsenring voted on patch set 6 V +1 CR +1 04/27/21, 19:45

  20. core-ci voted on patch set 6 V +1 04/27/21, 19:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10778

  21. Christian Kuhn voted on patch set 6 V +1 CR +1 04/27/21, 20:07

  22. Daniel Goerz voted on patch set 6 V +2 CR +2 04/27/21, 20:07

  23. Daniel Goerz merged patch set 7 04/27/21, 20:09