Review main Merged

67008[TASK] Mark properties and methods in ActionController internal

Alexander Schnitzler CR +2 V +2 Normal +120 −1 updated 12/08/20, 12:52

Commit message

Several properties and methods in the ActionController
are marked interal and will remain as is only until
TYPO3 11 LTS. From version 12.0 on, said properties and
methods may change or vanish without further notice.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Alexander Schnitzler uploaded patch set 1 12/05/20, 12:05

  2. TYPO3com voted on patch set 1 V +1 12/05/20, 12:15 Completed build in 09m 54s on Sat, 5 Dec, 12:15 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7825

  3. Alexander Schnitzler wrote 12/05/20, 15:44

    Topic set to extbase
  4. Benni Mack voted on patch set 1 V +1 CR +1 12/05/20, 21:22

  5. Benjamin Franzke commented on patch set 1 12/05/20, 22:03

    ActionController.php:428

    Hey, how do you think about usecases where processRequest() is extended (and $actionName is used) in order to catch \TYPO3\CMS\Extbase\Property\Exception\TargetNotFoundException and \TYPO3\CMS\Extbase\Property\Exception exceptions in order to send proper 4xx status codes, instead of "500 internal server error", when method arguments can not be resolved. E.g. https://github.com/georgringer/news/blob/8.5.0/Classes/Controller/NewsBaseController.php#L46-L86 Having this marked @internal makes those adaptions even more fragile – well, that must not be a bad thing, doing that in each and every controller is ugly anyway. But we should probably provide solutions for this usecase then. (I'm not saying that this blocks this patch, I'm just interested in your opinion).
  6. Alexander Schnitzler commented on patch set 1 12/06/20, 15:24

    ActionController.php:428 Reply

    Action name should be taken from the request in the future and extending processRequest is something I didn't think about yet but in my opinion, users should still have the possibility to react to errors. Having the core throw Exceptions I can only handle by overwriting code is a bad thing. Don't know how to solve this exactly but maybe it's possible to trigger the error action or a new action which can then be overwritten. Or we have something like we have with the middlewares where people can hook into and react to possible Exceptions. As soon as we have a full PSR-7 stack in Extbase we could easily introduce a PSR-15 approach there as well. However, my main idea still is to make the ActionController an optional helper class. > Having this marked @internal makes those adaptions even more fragile I think that's not a bad thing because then people will approach the core team and we get insights into real world usages.
  7. Alexander Schnitzler uploaded patch set 2 12/07/20, 11:49

  8. TYPO3com voted on patch set 2 V +1 12/07/20, 11:58 Completed build in 09m 03s on Mon, 7 Dec, 11:58 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7898

  9. Benjamin Franzke commented on patch set 2 V +1 CR +1 12/07/20, 20:08

    ActionController.php:428 Reply

    Ack
  10. Benni Mack voted on patch set 2 V +2 CR +2 12/08/20, 12:52

  11. Benni Mack merged patch set 3 12/08/20, 12:52