67011[TASK] Use icon identifier for backend modules
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 48
- Build/Gruntfile.js+1 −129
- typo3/sysext/adminpanel/Resources/Public/Icons/module-adminpanel.svgdeleted+0 −1
- typo3/sysext/backend/Resources/Public/Icons/module-about.svgdeleted+0 −1
- typo3/sysext/backend/Resources/Public/Icons/module-contentelements.svgdeleted+0 −1
- typo3/sysext/backend/Resources/Public/Icons/module-cshmanual.svgdeleted+0 −1
- typo3/sysext/backend/Resources/Public/Icons/module-page.svgdeleted+0 −1
- typo3/sysext/backend/Resources/Public/Icons/module-sites.svgdeleted+0 −1
- typo3/sysext/backend/Resources/Public/Icons/module-templates.svgdeleted+0 −1
- typo3/sysext/backend/Resources/Public/Icons/module-urls.svgdeleted+0 −1
- typo3/sysext/backend/ext_tables.php+4 −4
- typo3/sysext/belog/Resources/Public/Icons/module-belog.svgdeleted+0 −1
- typo3/sysext/belog/ext_tables.php+1 −1
- typo3/sysext/beuser/Resources/Public/Icons/module-beuser.svgdeleted+0 −1
- typo3/sysext/beuser/Resources/Public/Icons/module-permission.svgdeleted+0 −1
- typo3/sysext/beuser/ext_tables.php+2 −2
- typo3/sysext/dashboard/ext_tables.php+1 −1
- typo3/sysext/extensionmanager/Resources/Public/Icons/module-extensionmanager.svgdeleted+0 −1
- typo3/sysext/extensionmanager/ext_tables.php+1 −1
- typo3/sysext/filelist/Resources/Public/Icons/module-filelist.svgdeleted+0 −1
- typo3/sysext/filelist/ext_tables.php+1 −1
Show 28 more files
- typo3/sysext/form/Resources/Public/Icons/module-form.svgdeleted+0 −1
- typo3/sysext/form/ext_tables.php+1 −1
- typo3/sysext/indexed_search/Resources/Public/Icons/module-indexed_search.svgdeleted+0 −1
- typo3/sysext/info/Resources/Public/Icons/module-info.svgdeleted+0 −1
- typo3/sysext/info/ext_tables.php+1 −1
- typo3/sysext/install/Resources/Public/Icons/module-install-environment.svgdeleted+0 −1
- typo3/sysext/install/Resources/Public/Icons/module-install-maintenance.svgdeleted+0 −1
- typo3/sysext/install/Resources/Public/Icons/module-install-settings.svgdeleted+0 −1
- typo3/sysext/install/Resources/Public/Icons/module-install-upgrade.svgdeleted+0 −1
- typo3/sysext/install/Resources/Public/Icons/module-install.svgdeleted+0 −1
- typo3/sysext/install/ext_localconf.php+0 −16
- typo3/sysext/lowlevel/ext_tables.php+2 −2
- typo3/sysext/recordlist/Resources/Public/Icons/module-list.svgdeleted+0 −1
- typo3/sysext/recordlist/ext_tables.php+1 −1
- typo3/sysext/recycler/ext_tables.php+1 −1
- typo3/sysext/redirects/ext_tables.php+1 −1
- typo3/sysext/reports/Resources/Public/Icons/module-reports.svgdeleted+0 −1
- typo3/sysext/reports/ext_tables.php+1 −1
- typo3/sysext/scheduler/Resources/Public/Icons/module-scheduler.svgdeleted+0 −1
- typo3/sysext/scheduler/ext_tables.php+1 −1
- typo3/sysext/setup/Resources/Public/Icons/module-setup.svgdeleted+0 −1
- typo3/sysext/setup/ext_tables.php+1 −1
- typo3/sysext/tstemplate/Resources/Public/Icons/module-tstemplate.svgdeleted+0 −1
- typo3/sysext/tstemplate/ext_tables.php+1 −1
- typo3/sysext/viewpage/Resources/Public/Icons/module-viewpage.svgdeleted+0 −1
- typo3/sysext/viewpage/ext_tables.php+1 −1
- typo3/sysext/workspaces/Resources/Public/Icons/module-workspaces.svgdeleted+0 −1
- typo3/sysext/workspaces/ext_tables.php+1 −1
Review log 69
-
Andreas Kienast uploaded patch set 1 12/06/20, 10:23
-
TYPO3com voted on patch set 1 V -1 12/06/20, 10:32 Completed build in 08m 48s on Sun, 6 Dec, 10:32 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7846
-
Martin Kutschker commented on patch set 1 12/06/20, 17:40
I don't think that files should be removed from 10.4, part of an official API or not. Better mark the patch as breaking so nobody can complain that they are gone. But I have no strong opnion on this. -
Andreas Kienast commented on patch set 1 12/06/20, 17:46
Reply Unresolved
Benni opted to keep the icons in v10. so, the backport will touch the php files, only. -
Andreas Kienast uploaded patch set 2 12/06/20, 19:04
-
Andreas Kienast uploaded patch set 3 12/06/20, 19:04
-
TYPO3com voted on patch set 2 V +1 12/06/20, 19:13 Completed build in 08m 51s on Sun, 6 Dec, 07:13 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7876
-
TYPO3com voted on patch set 3 V +1 12/06/20, 19:16 Completed build in 09m 06s on Sun, 6 Dec, 07:16 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7877
-
Andreas Kienast abandoned the change 12/07/20, 06:57
After putting this change to sleep for one night I think this solution is not technically correct as it couples all extensions tighter to EXT:core where it isn't necessary.