Review main Abandoned

67011[TASK] Use icon identifier for backend modules

Andreas Kienast CR 0 V 0 Normal +24 −196 updated 12/07/20, 06:57

Commit message

In this change, all backend modules refer to their respective icons by
the given icon identifier instead of using a hard-coded icon.

The icons are part of the icon repository and lay in
`EXT:core/Resources/Public/T3Icons/svgs/module/`. With using these
icons, the previously used assets can be removed from their respective
extensions.

Since assets of extensions aren't "API" and one must not rely on their
existence, this patch is considered not being breaking!

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 48

Show 28 more files

Review log 69

  1. Andreas Kienast uploaded patch set 1 12/06/20, 10:23

  2. TYPO3com voted on patch set 1 V -1 12/06/20, 10:32 Completed build in 08m 48s on Sun, 6 Dec, 10:32 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7846

  3. Martin Kutschker commented on patch set 1 12/06/20, 17:40

    I don't think that files should be removed from 10.4, part of an official API or not. Better mark the patch as breaking so nobody can complain that they are gone. But I have no strong opnion on this.
  4. Andreas Kienast commented on patch set 1 12/06/20, 17:46

    Reply Unresolved

    Benni opted to keep the icons in v10. so, the backport will touch the php files, only.
  5. Andreas Kienast uploaded patch set 2 12/06/20, 19:04

  6. Andreas Kienast uploaded patch set 3 12/06/20, 19:04

  7. TYPO3com voted on patch set 2 V +1 12/06/20, 19:13 Completed build in 08m 51s on Sun, 6 Dec, 07:13 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7876

  8. TYPO3com voted on patch set 3 V +1 12/06/20, 19:16 Completed build in 09m 06s on Sun, 6 Dec, 07:16 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7877

  9. Andreas Kienast abandoned the change 12/07/20, 06:57

    After putting this change to sleep for one night I think this solution is not technically correct as it couples all extensions tighter to EXT:core where it isn't necessary.