Review main Merged Breaking

67033[!!!][TASK] PageRenderer should only render a full page

Benni Mack CR +2 V +2 Normal +92 −24 updated 12/07/20, 10:31

Commit message

PageRenderer->render() does not accept any arguments anymore.

This change allows to later-on hand in a Request object
into the PageRenderer and/or continue building a generic
View for rendering content, without marker-based changes.

In addition, the corresponding constants are now marked as
protected.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 610

  1. Benni Mack uploaded patch set 1 12/06/20, 12:45

  2. TYPO3com voted on patch set 1 V -1 12/06/20, 13:51 Completed build in 1h 05m 47s on Sun, 6 Dec, 01:51 PM Test Summary: 31324 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7851

  3. TYPO3com commented on patch set 1 12/06/20, 15:18 Completed build in 3h 38m 47s on Sun, 6 Dec, 03:18 PM Test Summary: 31324 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7851

  4. Benni Mack uploaded patch set 2 12/06/20, 15:31

  5. TYPO3com voted on patch set 2 V +1 12/06/20, 15:41 Completed build in 10m 03s on Sun, 6 Dec, 03:41 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7864

  6. Oli Bartsch uploaded patch set 3 12/07/20, 09:24

  7. Oli Bartsch voted on patch set 3 V +1 CR +1 12/07/20, 09:24

  8. TYPO3com voted on patch set 3 V +1 12/07/20, 09:34 Completed build in 09m 53s on Mon, 7 Dec, 09:34 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7893

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 12/07/20, 10:31

  10. Christian Kuhn merged patch set 4 12/07/20, 10:31