Review main Merged

67038[BUGFIX] Do not emit redirect() via PHP but via PSR-7

Benni Mack CR +2 V +2 Easy +17 −11 updated 12/07/20, 07:23

Commit message

In order to allow further manipulation of Response objects,
using "throw new ImmediateResponseException" is much
more flexible than calling HttpUtility::redirect() which immediately
stops the PHP process. This way, it is not even possible
for developers to manipulate the response, or even
test this behavior in functional tests with TYPO3 Core.

The change removes all usages of HttpUtility::redirect().
The method will be deprecated at a later stage.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Daniel Gorges +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 69

  1. Benni Mack uploaded patch set 1 12/06/20, 15:56

  2. TYPO3com voted on patch set 1 V -1 12/06/20, 16:05 Completed build in 09m 20s on Sun, 6 Dec, 04:05 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7866

  3. TYPO3com commented on patch set 1 12/06/20, 16:18 Completed build in 31m 36s on Sun, 6 Dec, 04:18 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7866

  4. Benni Mack uploaded patch set 2 12/06/20, 16:24

  5. TYPO3com voted on patch set 2 V +1 12/06/20, 16:33 Completed build in 09m 07s on Sun, 6 Dec, 04:33 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7868

  6. Benjamin Franzke voted on patch set 2 V +1 CR +1 12/06/20, 18:14

  7. Daniel Gorges voted on patch set 2 V +1 CR +1 12/07/20, 06:51

  8. Benjamin Franzke voted on patch set 2 V +2 CR +2 12/07/20, 07:23

  9. Benjamin Franzke merged patch set 3 12/07/20, 07:23