67040[TASK] Move database queries of linkvalidator to separate class
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 2028
Show 23 earlier messages
-
Sybille Peters uploaded patch set 1 12/06/20, 17:22
-
Sybille Peters wrote 12/06/20, 17:22
Topic set to Linkvalidator -
TYPO3com voted on patch set 1 V +1 12/06/20, 17:32 Completed build in 09m 44s on Sun, 6 Dec, 05:32 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7873
-
Stephan Großberndt updated the commit message in patch set 2 12/06/20, 19:00
-
TYPO3com voted on patch set 2 V +1 12/06/20, 19:09 Completed build in 08m 44s on Sun, 6 Dec, 07:09 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7875
-
Sybille Peters uploaded patch set 3 12/07/20, 15:07
-
TYPO3com voted on patch set 3 V -1 12/07/20, 15:18 Completed build in 09m 35s on Mon, 7 Dec, 03:18 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7920
-
Oli Bartsch commented on patch set 3 CR -1 12/07/20, 16:24
Added file `out` seems wrong :)LinkValidatorReport.php:151Would suggest to simplify this constructor to use null coalescing operator. $this->pagesRepository = $pagesRepository ?? GeneralUtility::makeInstance(PagesRepository::class); $this->brokenLinkRepository = $brokenLinkRepository ?? GeneralUtility::makeInstance(BrokenLinkRepository::class);PagesRepository.php:28This should be @internal.PagesRepository.php:44Since we introduce new functions I would suggest to also introduce strict type checking (applies to the whole class). In this case this could be: (int)$pageInfo['extendToSubpages'] === 1 && (int)$pageInfo['hidden'] === 1 -
Sybille Peters uploaded patch set 4 12/07/20, 16:50
-
Sybille Peters commented on patch set 4 12/07/20, 16:51
Reply
done Must have been the cat running over my keyboard.I now added type declarations to all functions in PagesRepository and changed the code for the calling code accordingly.LinkValidatorReport.php:151ReplyDonePagesRepository.php:28ReplyDonePagesRepository.php:44ReplyDone -
Sybille Peters uploaded patch set 5 12/07/20, 16:53
-
Sybille Peters uploaded patch set 6 12/07/20, 16:56
-
TYPO3com voted on patch set 5 V -1 12/07/20, 16:58 Completed build in 54s on Mon, 7 Dec, 04:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7926
-
TYPO3com voted on patch set 4 V -1 12/07/20, 16:58 Completed build in 59s on Mon, 7 Dec, 04:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7925
-
TYPO3com voted on patch set 6 V +1 12/07/20, 17:19 Completed build in 21m 55s on Mon, 7 Dec, 05:19 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7927
-
Benni Mack commented on patch set 6 12/07/20, 21:23
PagesRepository.php:86could we then just rename this method? I do hate this name so much (and I know why it was called like that). it's actually "getIdsOfSubpages()" and it should return an array (more specifically int[]), because imploding/exploding all the time is deemed for hell. -
Benni Mack uploaded patch set 7 12/07/20, 21:44
-
TYPO3com voted on patch set 7 V -1 12/07/20, 21:54 Completed build in 09m 27s on Mon, 7 Dec, 09:54 PM Test Summary: 9 of 32652 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7944
-
Sybille Peters commented on patch set 7 12/07/20, 22:00
PagesRepository.php:86Reply UnresolvedI already changed the csv to array in several places in patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/66315 but this never got merged. I am all for using an array because using the csv string has no benefit at all. -
Sybille Peters commented on patch set 7 12/07/20, 22:02
PagesRepository.php:119$theList should get removed.PagesRepository.php:123Would it be more efficient to pass a reference to subpageIds to the function and not do an array_merge for each recursion? -
Sybille Peters uploaded patch set 8 12/08/20, 07:53
-
TYPO3com voted on patch set 8 V +1 12/08/20, 08:02 Completed build in 09m 20s on Tue, 8 Dec, 08:02 AM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7947
-
Benni Mack commented on patch set 8 12/08/20, 10:43
PagesRepository.php:119ReplyAckPagesRepository.php:123Replythe impact is little, let's put it this way. if we'd call this method 1000 times from the outside, we could / should profile it. but in this case, it's OK, because it has less side-effects ("was this array changed? can I get the difference of the things that have changed?") and it makes it easier to add tests. -
Sybille Peters commented on patch set 8 12/08/20, 11:11
PagesRepository.php:119Replydone -
Benni Mack voted on patch set 8 V +1 CR +1 12/08/20, 12:01
-
Oli Bartsch voted on patch set 8 V +1 CR +1 12/08/20, 12:04
-
Benni Mack voted on patch set 8 V +2 CR +2 12/08/20, 12:53
-
Benni Mack merged patch set 9 12/08/20, 12:53