Review main Merged

67043[BUGFIX] Respect none accessible workspace pages in tree list

Daniel Siepmann CR +2 V +2 Easy +3 −1 updated 12/07/20, 14:37

Commit message

If a versioned page is inaccessible due to versionOL, the row will be
converted to a value of "false". This can be the case for deleted or hidden pages.
In those cases, the tree should not include this page.
Keeping the page would furthermore result in a type error, as later
calls expect $row to be an array.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Daniel Siepmann uploaded patch set 1 12/07/20, 08:56

  2. TYPO3com voted on patch set 1 V +1 12/07/20, 09:05 Completed build in 09m 06s on Mon, 7 Dec, 09:05 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7890

  3. Benni Mack voted on patch set 1 CR +1 12/07/20, 09:10

  4. Benjamin Franzke commented on patch set 1 CR +1 12/07/20, 09:14

    minor thing: "inaccessible", right?
  5. Benjamin Franzke voted on patch set 1 V +1 12/07/20, 10:58

  6. Benni Mack voted on patch set 1 V +2 CR +2 12/07/20, 11:51

  7. Benni Mack updated the commit message in patch set 2 12/07/20, 11:51

  8. TYPO3com voted on patch set 2 V +1 12/07/20, 12:01 Completed build in 09m 59s on Mon, 7 Dec, 12:01 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7899

  9. Oli Bartsch voted on patch set 2 V +1 CR +1 12/07/20, 13:03

  10. Benni Mack voted on patch set 2 V +1 CR +1 12/07/20, 14:32

  11. Benjamin Franzke voted on patch set 2 V +2 CR +2 12/07/20, 14:36

  12. Benjamin Franzke commented on patch set 2 12/07/20, 14:37

    Reply

    Done
  13. Benjamin Franzke merged patch set 3 12/07/20, 14:37