Review main Merged

67045[TASK] Centralize Backend User Session Repository

Benni Mack CR +2 V +2 Normal +48 −89 updated 12/07/20, 14:10

Commit message

Logic around Backend User Sessions and its access
across the EXT:beuser backend module is now encapsulated
and streamlined:

* The BackendUserSessionRepository does not inherit
from Extbase anymore, as there is nothing needed here
* No ObjectManager is needed, GeneralUtility can be used instead
* All access to the actual sessionBackend is now placed inside
this method.

This allows to further streamline the User Session handling
at a later stage.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 57

  1. Benni Mack uploaded patch set 1 12/07/20, 13:19

  2. TYPO3com voted on patch set 1 V -1 12/07/20, 13:29 Completed build in 10m 02s on Mon, 7 Dec, 01:29 PM Test Summary: 2 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7903

  3. Oli Bartsch uploaded patch set 2 12/07/20, 13:56

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 12/07/20, 14:06

  5. TYPO3com voted on patch set 2 V +1 12/07/20, 14:08 Completed build in 11m 31s on Mon, 7 Dec, 02:08 PM Test Summary: 32409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7906

  6. Georg Ringer voted on patch set 2 V +2 CR +2 12/07/20, 14:10

  7. Georg Ringer merged patch set 3 12/07/20, 14:10