Review main Merged

67046[TASK] Remove unnecessary access of superglobals

Oli Bartsch CR +2 V +2 Easy +2 −12 updated 12/07/20, 15:16

Commit message

Since $loginType will be always 'BE' in this context, there is
no need to access $GLOBALS['BE_USER'] for this information.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Oli Bartsch uploaded patch set 1 12/07/20, 14:36

  2. Christian Kuhn voted on patch set 1 CR +1 12/07/20, 14:40

  3. TYPO3com voted on patch set 1 V -1 12/07/20, 14:43 Completed build in 01m 40s on Mon, 7 Dec, 02:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7916

  4. Oli Bartsch uploaded patch set 2 12/07/20, 14:45

  5. Benni Mack voted on patch set 2 V +1 CR +1 12/07/20, 14:53

  6. TYPO3com voted on patch set 2 V +1 12/07/20, 15:08 Completed build in 11m 16s on Mon, 7 Dec, 03:08 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7918

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 12/07/20, 15:16

  8. Christian Kuhn merged patch set 3 12/07/20, 15:16