Review main Merged

67047[TASK] Deprecate ControllerContext::getUriBuilder()

Alexander Schnitzler CR +2 V +2 Easy +17 −25 updated 12/08/20, 12:51

Commit message

With this patch method geturiBuilder() of ControllerContext
is deprecated and the core avoids using it.

A trigger_error call will be implemented in another patch set
which deprecates the whole ControllerContext object.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 67

  1. Alexander Schnitzler uploaded patch set 1 12/07/20, 16:03

  2. Alexander Schnitzler wrote 12/07/20, 16:03

    Topic set to extbase
  3. Benni Mack voted on patch set 1 CR +1 12/07/20, 16:15

  4. TYPO3com voted on patch set 1 V +1 12/07/20, 16:28 Completed build in 24m 13s on Mon, 7 Dec, 04:28 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7923

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 12/08/20, 12:51

  6. Benni Mack voted on patch set 1 V +2 CR +2 12/08/20, 12:51

  7. Benni Mack merged patch set 2 12/08/20, 12:51