Review main Merged

67048[BUGFIX] Fix negated isLoggedInBackendUserRequired() method

Benjamin Franzke CR +2 V +2 Easy +5 −4 updated 12/08/20, 16:09

Commit message

The method returned the opposite of what the function name
defines. It checks whether the current backend route
is a public route, and in that case it returned true. But if
a public route is requested, then a backend user is actually
*not* required.

The method was then used inverted, which contervailed this mistake.
Therefore there was no functional bug here, just a naming bug.

Therefore we now invert the result of this method.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 712

  1. Benjamin Franzke uploaded patch set 1 12/07/20, 19:00

  2. TYPO3com voted on patch set 1 V +1 12/07/20, 19:10 Completed build in 09m 45s on Mon, 7 Dec, 07:10 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7938

  3. Benjamin Franzke uploaded patch set 2 12/07/20, 19:10

  4. Benjamin Franzke updated the commit message in patch set 3 12/07/20, 19:11

  5. TYPO3com voted on patch set 2 V +1 12/07/20, 19:19 Completed build in 09m 14s on Mon, 7 Dec, 07:19 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7939

  6. TYPO3com voted on patch set 3 V +1 12/07/20, 19:23 Completed build in 11m 13s on Mon, 7 Dec, 07:23 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7940

  7. Benni Mack voted on patch set 3 V +1 CR +1 12/07/20, 21:08

  8. Benjamin Franzke uploaded patch set 4 12/08/20, 07:43

  9. TYPO3com voted on patch set 4 V -1 12/08/20, 07:54 Completed build in 10m 41s on Tue, 8 Dec, 07:54 AM Test Summary: 30340 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7946

  10. TYPO3com voted on patch set 4 V +1 12/08/20, 08:11 Completed build in 09m 11s on Tue, 8 Dec, 08:11 AM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7948

  11. Benni Mack voted on patch set 4 V +2 CR +2 12/08/20, 16:09

  12. Benni Mack merged patch set 5 12/08/20, 16:09