Review main Merged

67074[TASK] Change page unavailable status code from 500 to 503

TYPO3com CR +2 V +2 Easy +5 −5 updated 12/10/20, 08:43

Commit message

Page unavailable (e.g. maintenance mode) is a "503 service unavailable"
error, not 500 internal server error.
If TYPO3 is in maintenance mode then a 503 error is now thrown.
Also 503 Error Handlers are taken into account now.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1015

  1. TYPO3com uploaded patch set 1 12/09/20, 02:42

  2. TYPO3com voted on patch set 1 V -1 12/09/20, 02:53 Completed build in 10m 46s on Wed, 9 Dec, 02:53 AM Test Summary: 4 of 32648 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7981

  3. Christian Kuhn uploaded patch set 2 12/09/20, 13:47

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 12/09/20, 13:48

  5. Benjamin Franzke voted on patch set 2 CR +1 12/09/20, 13:56

  6. TYPO3com voted on patch set 2 V -1 12/09/20, 14:00 Completed build in 12m 07s on Wed, 9 Dec, 02:00 PM Test Summary: 1 of 31819 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7997

  7. Benjamin Franzke commented on patch set 2 12/09/20, 14:01

    Would love a backport for v10, what do you thing, Christian? That'd be "breaking" for users that registered a 500 error handler.
  8. Christian Kuhn commented on patch set 2 12/09/20, 14:08

    Reply Unresolved

    Yeah. Unsure. 503 is clearly the more correct status here. I'm unsure how many instances actually run a custom 500 error handler ... My gut feeling was to not backport to not risk any trouble in this area.
  9. TYPO3com voted on patch set 2 V +1 12/09/20, 14:08 Completed build in 32m 54s on Wed, 9 Dec, 02:08 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7997

  10. Benjamin Franzke updated the commit message in patch set 3 12/09/20, 14:11

  11. Christian Kuhn commented on patch set 3 V +1 CR +1 12/09/20, 14:13

    ok, fine with me.
  12. TYPO3com voted on patch set 3 V +1 12/09/20, 14:26 Completed build in 15m 22s on Wed, 9 Dec, 02:26 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8000

  13. Benni Mack voted on patch set 3 V +2 CR +2 12/09/20, 14:28

  14. Benni Mack merged patch set 4 12/09/20, 14:28

  15. Benjamin Franzke commented on patch set 4 12/10/20, 08:43

    Follow refactoring for frontend 500 vs 503 status codes: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67080