67075[TASK] Avoid further usages of ControllerContext methods
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayoutViewHelper.php+12 −1
- typo3/sysext/extbase/Configuration/Services.yaml3+4 −0
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php+2 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ReloadSqlDataViewHelper.php+2 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/RemoveExtensionViewHelper.php+2 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php+3 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/UpdateScriptViewHelper.php+2 −1
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContext.php+4 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemViewHelper.php+6 −1
- typo3/sysext/fluid/Classes/ViewHelpers/FlashMessagesViewHelper.php+16 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/FlashMessagesViewHelperTest.php+14 −2
Review log 1217
-
Alexander Schnitzler uploaded patch set 1 12/09/20, 10:56
-
TYPO3com voted on patch set 1 V -1 12/09/20, 11:15 Completed build in 18m 20s on Wed, 9 Dec, 11:15 AM Test Summary: 9 of 24264 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7984
-
Alexander Schnitzler uploaded patch set 2 12/09/20, 11:24
-
TYPO3com voted on patch set 2 V -1 12/09/20, 11:34 Completed build in 09m 57s on Wed, 9 Dec, 11:34 AM Test Summary: 9 of 32648 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7987
-
Alexander Schnitzler uploaded patch set 3 12/09/20, 11:41
-
TYPO3com voted on patch set 3 V +1 12/09/20, 11:51 Completed build in 09m 44s on Wed, 9 Dec, 11:51 AM Test Summary: 32407 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7989
-
Alexander Schnitzler updated the commit message in patch set 4 12/09/20, 11:53
-
TYPO3com voted on patch set 4 V +1 12/09/20, 12:02 Completed build in 09m 24s on Wed, 9 Dec, 12:02 PM Test Summary: 32407 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7991
-
Christian Kuhn voted on patch set 4 CR +1 12/09/20, 17:33
-
Benni Mack commented on patch set 4 12/10/20, 13:20
-
Alexander Schnitzler commented on patch set 4 CR -1 12/10/20, 13:34
Services.yaml:49ReplyNo, you get it. This is a mistake and the reason I pushed the last patch set which adds the initialization. I forgot to adjust the shared flag. UriBuilder must not be shared of course because it is stateful. -
Alexander Schnitzler uploaded patch set 5 12/10/20, 13:35
-
TYPO3com voted on patch set 5 V +1 12/10/20, 13:44 Completed build in 09m 15s on Thu, 10 Dec, 01:44 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8017
-
Alexander Schnitzler commented on patch set 5 12/10/20, 14:29
Services.yaml:49ReplyDone -
Benni Mack commented on patch set 5 V +1 CR +1 12/10/20, 14:35
Thanks for the clarification! -
Christian Kuhn voted on patch set 5 V +2 CR +2 12/10/20, 14:38
-
Christian Kuhn merged patch set 6 12/10/20, 14:39
Services.yaml:49