Review main Merged

67075[TASK] Avoid further usages of ControllerContext methods

Alexander Schnitzler CR +2 V +2 Normal +67 −12 updated 12/10/20, 14:39

Commit message

This patch avoids further undetected usages of deprecated
methods:

- ControllerContext::getFlashMessageQueue()
- ControllerContext::getUriBuilder()

Those methods have been called on a controller context
instance obtained by the rendering context.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 1217

  1. Alexander Schnitzler uploaded patch set 1 12/09/20, 10:56

  2. TYPO3com voted on patch set 1 V -1 12/09/20, 11:15 Completed build in 18m 20s on Wed, 9 Dec, 11:15 AM Test Summary: 9 of 24264 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7984

  3. Alexander Schnitzler uploaded patch set 2 12/09/20, 11:24

  4. TYPO3com voted on patch set 2 V -1 12/09/20, 11:34 Completed build in 09m 57s on Wed, 9 Dec, 11:34 AM Test Summary: 9 of 32648 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7987

  5. Alexander Schnitzler uploaded patch set 3 12/09/20, 11:41

  6. TYPO3com voted on patch set 3 V +1 12/09/20, 11:51 Completed build in 09m 44s on Wed, 9 Dec, 11:51 AM Test Summary: 32407 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7989

  7. Alexander Schnitzler updated the commit message in patch set 4 12/09/20, 11:53

  8. TYPO3com voted on patch set 4 V +1 12/09/20, 12:02 Completed build in 09m 24s on Wed, 9 Dec, 12:02 PM Test Summary: 32407 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7991

  9. Christian Kuhn voted on patch set 4 CR +1 12/09/20, 17:33

  10. Benni Mack commented on patch set 4 12/10/20, 13:20

    Services.yaml:49

    maybe I just don't get DI... but can you elaborate why Extbase's UriBuilder is turned into a shared service? AFAIK if you have a UriBuilder instance "per plugin" and you have two plugins on a page, it should be reinitialized for each usage, and not contain state from the last plugin / cObject?
  11. Alexander Schnitzler commented on patch set 4 CR -1 12/10/20, 13:34

    Services.yaml:49 Reply

    No, you get it. This is a mistake and the reason I pushed the last patch set which adds the initialization. I forgot to adjust the shared flag. UriBuilder must not be shared of course because it is stateful.
  12. Alexander Schnitzler uploaded patch set 5 12/10/20, 13:35

  13. TYPO3com voted on patch set 5 V +1 12/10/20, 13:44 Completed build in 09m 15s on Thu, 10 Dec, 01:44 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8017

  14. Alexander Schnitzler commented on patch set 5 12/10/20, 14:29

    Services.yaml:49 Reply

    Done
  15. Benni Mack commented on patch set 5 V +1 CR +1 12/10/20, 14:35

    Thanks for the clarification!
  16. Christian Kuhn voted on patch set 5 V +2 CR +2 12/10/20, 14:38

  17. Christian Kuhn merged patch set 6 12/10/20, 14:39