Review main Merged

67076[TASK] Cleanup ReferenceIndex class

Christian Kuhn CR +2 V +2 Hard +128 −153 updated 12/09/20, 15:16

Commit message

* Since introduction of class ReferenceIndexUpdater each
  record is handled only once when updating the reference
  index. The record runtime cache is obsolete and can be
  dropped.

* The $excludedTables and $excludedColumns properties are
  non-static now: In normal operation only one instance
  of ReferenceIndex class is created and used for many
  records, there is no point in creating hard to evict
  static state.

* A runtime cache has been used for information derived
  from TCA (no db calls). This is dropped in favor of a
  class property.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 1015

  1. Christian Kuhn uploaded patch set 1 12/09/20, 11:41

  2. TYPO3com voted on patch set 1 V -1 12/09/20, 11:41 Completed build in 26s on Wed, 9 Dec, 11:41 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7988

  3. Christian Kuhn uploaded patch set 2 12/09/20, 11:46

  4. TYPO3com voted on patch set 2 V +1 12/09/20, 11:55 Completed build in 09m 41s on Wed, 9 Dec, 11:55 AM Test Summary: 32407 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7990

  5. Christian Kuhn uploaded patch set 3 12/09/20, 13:16

  6. TYPO3com voted on patch set 3 V +1 12/09/20, 13:27 Completed build in 10m 43s on Wed, 9 Dec, 01:27 PM Test Summary: 32407 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7995

  7. Benni Mack commented on patch set 3 12/09/20, 13:51

    ReferenceIndex.php:126 Unresolved

    you can now remove this comment :D

    ReferenceIndex.php:1121

    you add a list, and then make a an array out of it. implode/explode -> not needed. could can be simplified.
  8. Oli Bartsch uploaded patch set 4 12/09/20, 13:55

  9. Christian Kuhn commented on patch set 4 12/09/20, 13:58

    ReferenceIndex.php:1121 Reply Unresolved

    lol. right. thx.
  10. TYPO3com voted on patch set 4 V +1 12/09/20, 14:06 Completed build in 11m 02s on Wed, 9 Dec, 02:06 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7998

  11. Oli Bartsch uploaded patch set 5 12/09/20, 14:11

  12. Oli Bartsch voted on patch set 5 V +1 CR +1 12/09/20, 14:20

  13. TYPO3com voted on patch set 5 V +1 12/09/20, 14:21 Completed build in 09m 52s on Wed, 9 Dec, 02:21 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7999

  14. Benni Mack voted on patch set 5 V +2 CR +2 12/09/20, 15:16

  15. Benni Mack merged patch set 6 12/09/20, 15:16