Review main Merged

67077[TASK] Test ClassSchema detects php 7.4 property types

Alexander Schnitzler CR +2 V +2 Easy +28 −0 updated 12/09/20, 13:40

Commit message

Since TYPO3 11 requires php >= 7.4 and since symfony
components support php 7.4 type hint evaluations as
well, some tests have been added to verify that when
building ClassSchema instances, property types are
properly detected.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 79

  1. Alexander Schnitzler uploaded patch set 1 12/09/20, 12:44

  2. Alexander Schnitzler wrote 12/09/20, 12:45

    Topic set to extbase
  3. TYPO3com voted on patch set 1 V -1 12/09/20, 12:54 Completed build in 09m 53s on Wed, 9 Dec, 12:54 PM Test Summary: 2 of 32652 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7993

  4. Alexander Schnitzler uploaded patch set 2 12/09/20, 12:56

  5. TYPO3com voted on patch set 2 V +1 12/09/20, 13:05 Completed build in 08m 34s on Wed, 9 Dec, 01:05 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7994

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 12/09/20, 13:39

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 12/09/20, 13:40

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 12/09/20, 13:40

  9. Christian Kuhn merged patch set 3 12/09/20, 13:40