Review 10.4 Merged

67079[BUGFIX] Revert method signature change

Georg Ringer CR +2 V +2 Easy +4 −5 updated 12/10/20, 08:55

Commit message

With #92682 the method `renderForeignRecordHeader` has been changed
which is bad for extensions which xclasses this method.
Put the new parameter into the data array to minimize the impact of the
accessibility change.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 67

  1. Georg Ringer uploaded patch set 1 12/10/20, 07:41

  2. Georg Ringer commented on patch set 1 12/10/20, 07:41

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 12/10/20, 07:53 Completed build in 11m 23s on Thu, 10 Dec, 07:52 AM Test Summary: 75235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-894

  4. Benni Mack voted on patch set 1 V +1 CR +1 12/10/20, 08:04

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 12/10/20, 08:49

  6. Benni Mack voted on patch set 1 V +2 CR +2 12/10/20, 08:55

  7. Benni Mack merged patch set 2 12/10/20, 08:55