Review main Merged

6708[BUGFIX] typolink prepends wrong domain when using url scheme

Dmitry Dulepov CR +2 V +2 Easy +5 −5 updated 06/03/13, 20:49

Commit message

tslib_cObj::typoLink() uses a wrong domain if the target page
has a domain record and a URL scheme, which is different to
current. It prepends a current domain instead of the target
domain of the page.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Markus Klein +1
    • Dominik Mathern +1
    • Oliver Hader +1
  • Verified V +2
    • Steffen Ritter +2
    • Dominik Mathern +1
    • Oliver Hader +1

Issues 1

Files 1

Review log 20

  1. Dmitry Dulepov commented on patch set 1 12/18/11, 10:18

    Yes, that is to be pushed soon. Why -1 to this push???
  2. Markus Klein commented on patch set 1 12/18/11, 10:18

    I would prefer that you didn't submit this
    Other branches are missing.
  3. Dmitry Dulepov commented on patch set 2 12/18/11, 10:18

    Steffen, I am posting the fix for all branches. I am not going to track this. It is not efficient. I believe we have no rule in the core team that says not to post for older branches. So we are free to do that.
  4. Dmitry Dulepov commented on patch set 2 12/18/11, 10:18

    I would prefer that you didn't submit this Marcus, please, have a look to the workflow: http://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine#Backporting_a_change_to_other_branches Pushing to other branches requires a separate push! This patch is for release 4.7 only.
  5. Dmitry Dulepov commented on patch set 2 12/18/11, 10:18

    No score
  6. Stefan Neufeind commented on patch set 2 12/18/11, 10:18

    Looks good to me, but someone else must approve
  7. Markus Klein commented on patch set 2 12/18/11, 10:18

    Looks good to me, but someone else must approve
  8. Markus Klein uploaded patch set 2 12/18/11, 10:18

  9. Markus Klein commented on patch set 2 12/18/11, 10:18

    As far as I know we need all affected releases in the list.
  10. Markus Klein commented on patch set 2 12/18/11, 10:18

  11. Markus Klein commented on patch set 3 12/18/11, 10:18

    Looks good to me, but someone else must approve
  12. Oliver Hader commented on patch set 3 12/18/11, 10:18

    Verified; Looks good to me, but someone else must approve Rebasing to master V:1, R:1 V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> V:0, R:1 from Markus Klein <klein.t3@mfc-linz.at> V:1, R:1 from Steffen Ritter <info@rs-websystems.de>
  13. Oliver Hader uploaded patch set 3 12/18/11, 10:18

  14. Steffen Ritter commented on patch set 2 12/18/11, 10:18

    Verified; Looks good to me, but someone else must approve guys please - gerrit is not meant to be for discussions. Please use the core list or dev list for such. Anyhow, the change of Markus was correct (all versions have to be listed) and master has to be done first. So please conenctrate on maste first and backport later
  15. Mr. Jenkins commented on patch set 1 12/18/11, 10:18

  16. Mr. Jenkins commented on patch set 2 12/18/11, 10:18

  17. Mr. Jenkins commented on patch set 3 12/18/11, 10:18

  18. Dominik Mathern commented on patch set 3 12/18/11, 10:18

    Verified; Looks good to me, but someone else must approve
  19. Steffen Ritter commented on patch set 3 V 0 12/18/11, 10:18

    by team member; Looks good to me, approved
  20. Steffen Ritter merged patch set 3 12/18/11, 10:18