Review main Merged Breaking

67082[!!!][TASK] Streamline send-no-cache headers

Benni Mack CR +2 V +2 Normal +56 −38 updated 12/10/20, 17:21

Commit message

The public property $sendNoCacheHeaders of
AbstractUserAuthentication is now fully put into
PSR-15 middlewares, which decide on their own
if headers diasallowing HTTP caches should be sent to the client.

This change removes the property, as the PSR-15 middlewares
set the headers already since TYPO3 v10.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 811

  1. Benni Mack uploaded patch set 1 12/10/20, 12:48

  2. TYPO3com voted on patch set 1 V +1 12/10/20, 13:00 Completed build in 11m 53s on Thu, 10 Dec, 01:00 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8016

  3. Christian Kuhn commented on patch set 1 CR -1 12/10/20, 13:23

    FrontendUserAuthenticator.php:80

    Imho not ok: always sending no cache headers just because a fe user is logged in.
  4. Benni Mack uploaded patch set 2 12/10/20, 16:17

  5. Benni Mack uploaded patch set 3 12/10/20, 16:25

  6. TYPO3com voted on patch set 2 V -1 12/10/20, 16:29 Completed build in 11m 56s on Thu, 10 Dec, 04:29 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8021

  7. TYPO3com voted on patch set 3 V +1 12/10/20, 16:38 Completed build in 11m 18s on Thu, 10 Dec, 04:38 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8023

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 12/10/20, 16:45

  9. Christian Kuhn commented on patch set 3 12/10/20, 16:46

    FrontendUserAuthenticator.php:80 Reply

    Done
  10. Daniel Goerz voted on patch set 3 V +2 CR +2 12/10/20, 17:21

  11. Daniel Goerz merged patch set 4 12/10/20, 17:21