Review main Merged Breaking

67086[!!!][TASK] Remove forceSetCookie from AbstractUserAuthentication

Benni Mack CR +2 V +2 Normal +53 −8 updated 12/14/20, 15:27

Commit message

The option "forceSetCookie", previously used
for lifetime, is only set in FrontendUserAuthentication,
and is moved to that subclass as a protected property,
making the dependencies between the parent class and the main class
cleaner.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1015

  1. Benni Mack uploaded patch set 1 12/10/20, 16:39

  2. TYPO3com voted on patch set 1 V -1 12/10/20, 16:53 Completed build in 13m 30s on Thu, 10 Dec, 04:53 PM Test Summary: 31678 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8024

  3. TYPO3com voted on patch set 1 V +1 12/10/20, 20:21 Completed build in 3h 55m 44s on Thu, 10 Dec, 08:21 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8024

  4. Benni Mack updated the commit message in patch set 2 12/14/20, 12:39

  5. TYPO3com voted on patch set 2 V -1 12/14/20, 12:56 Completed build in 13m 17s on Mon, 14 Dec, 12:56 PM Test Summary: 1 of 32656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8159

  6. Benni Mack uploaded patch set 3 12/14/20, 14:22

  7. TYPO3com voted on patch set 3 V +1 12/14/20, 14:31 Completed build in 08m 57s on Mon, 14 Dec, 02:31 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8165

  8. Benjamin Franzke uploaded patch set 4 12/14/20, 14:55

  9. Benjamin Franzke commented on patch set 4 12/14/20, 14:55

    Breaking-93073-AbstractUserAuthentication-forceSetCookieRemoved.rst:17

    moved as
  10. Benjamin Franzke commented on patch set 4 12/14/20, 14:55

    Breaking-93073-AbstractUserAuthentication-forceSetCookieRemoved.rst:17 Reply

    Done
  11. TYPO3com voted on patch set 4 V +1 12/14/20, 15:05 Completed build in 09m 31s on Mon, 14 Dec, 03:05 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8170

  12. Andreas Kienast voted on patch set 4 CR +1 12/14/20, 15:11

  13. Oli Bartsch voted on patch set 4 V +1 CR +1 12/14/20, 15:24

  14. Benjamin Franzke voted on patch set 4 V +2 CR +2 12/14/20, 15:27

  15. Benjamin Franzke merged patch set 5 12/14/20, 15:27