Review TYPO3_4-6 Merged

6709[BUGFIX] typolink prepends wrong domain when using url scheme

Dmitry Dulepov CR +2 V +2 Easy +5 −5 updated 06/03/13, 20:49

Commit message

tslib_cObj::typoLink() uses a wrong domain if the target page
has a domain record and a URL scheme, which is different to
current. It prepends a current domain instead of the target
domain of the page.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Steffen Ritter +1
  • Verified V +2
    • Oliver Hader +2
    • Steffen Ritter +1

Issues 1

Files 1

Review log 13

  1. Dmitry Dulepov commented on patch set 1 01/24/12, 09:32

    Markus, please, explain why are you giving -1 to patches that already fix the issue!
  2. Markus Klein commented on patch set 1 01/24/12, 09:32

    I would prefer that you didn't submit this Will push new change that fixes this.
    Missing other branches here.
  3. Markus Klein commented on patch set 2 01/24/12, 09:32

    I would prefer that you didn't submit this Please vote in master first: https://review.typo3.org/6708
  4. Markus Klein commented on patch set 2 01/24/12, 09:32

    Because the commit message didn't conform to the requirements. And until I'm able to push a new version with a fixed message, I give a -1 to indicate that there's a problem.
  5. Markus Klein uploaded patch set 2 01/24/12, 09:32

  6. Markus Klein commented on patch set 3 01/24/12, 09:32

    No score
  7. Markus Klein commented on patch set 3 01/24/12, 09:32

    I would prefer that you didn't submit this Please vote in master first: https://review.typo3.org/6708
  8. Oliver Hader uploaded patch set 3 01/24/12, 09:32

  9. Oliver Hader commented on patch set 3 V 0 01/24/12, 09:32

    by team member; Looks good to me, approved
  10. Oliver Hader commented on patch set 3 01/24/12, 09:32

    I would prefer that you didn't submit this Automated rebasing to TYPO3_4-6 - Please consider updating your reviews V:0, R:-1 as a summary of previous scores (limited to [-1;+1]) V:0, R:-1 from Markus Klein <klein.t3@mfc-linz.at>
  11. Steffen Ritter commented on patch set 3 01/24/12, 09:32

    Verified; Looks good to me, but someone else must approve
  12. Philipp Gampe commented on patch set 3 01/24/12, 09:32

    Merged in master now :)
  13. Oliver Hader merged patch set 3 01/24/12, 09:32