6709[BUGFIX] typolink prepends wrong domain when using url scheme
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Steffen Ritter +1
-
Verified V +2
- Oliver Hader +2
- Steffen Ritter +1
Issues 1
Files 1
Review log 13
-
Dmitry Dulepov commented on patch set 1 01/24/12, 09:32
Markus, please, explain why are you giving -1 to patches that already fix the issue! -
Markus Klein commented on patch set 1 01/24/12, 09:32
I would prefer that you didn't submit this Will push new change that fixes this.Missing other branches here. -
Markus Klein commented on patch set 2 01/24/12, 09:32
I would prefer that you didn't submit this Please vote in master first: https://review.typo3.org/6708 -
Markus Klein commented on patch set 2 01/24/12, 09:32
Because the commit message didn't conform to the requirements. And until I'm able to push a new version with a fixed message, I give a -1 to indicate that there's a problem. -
Markus Klein uploaded patch set 2 01/24/12, 09:32
-
Markus Klein commented on patch set 3 01/24/12, 09:32
No score -
Markus Klein commented on patch set 3 01/24/12, 09:32
I would prefer that you didn't submit this Please vote in master first: https://review.typo3.org/6708 -
Oliver Hader uploaded patch set 3 01/24/12, 09:32
-
Oliver Hader commented on patch set 3 V 0 01/24/12, 09:32
by team member; Looks good to me, approved -
Oliver Hader commented on patch set 3 01/24/12, 09:32
I would prefer that you didn't submit this Automated rebasing to TYPO3_4-6 - Please consider updating your reviews V:0, R:-1 as a summary of previous scores (limited to [-1;+1]) V:0, R:-1 from Markus Klein <klein.t3@mfc-linz.at> -
Steffen Ritter commented on patch set 3 01/24/12, 09:32
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 3 01/24/12, 09:32
Merged in master now :) -
Oliver Hader merged patch set 3 01/24/12, 09:32