Review main Merged

67091[BUGFIX] Bind module menu event listener to document

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 12/11/20, 22:51

Commit message

With #91642 some event listeners were detached from the global document
object and reattached to better fitting DOM nodes to avoid pollution of
too many event listeners in document.

Unfortunately, this broke the module menu toggle after it has been
reloaded, e.g. after installing an extension via Extension Manager.

This change binds the event listener for the module menu state toggle to
the document object again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 913

  1. Andreas Kienast uploaded patch set 1 12/11/20, 08:07

  2. TYPO3com voted on patch set 1 V -1 12/11/20, 08:19 Completed build in 12m 07s on Fri, 11 Dec, 08:19 AM Test Summary: 11 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8053

  3. TYPO3com voted on patch set 1 V +1 12/11/20, 08:24 Completed build in 29m 17s on Fri, 11 Dec, 08:24 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8053

  4. Oli Bartsch updated the commit message in patch set 2 12/11/20, 08:42

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 12/11/20, 08:43

  6. TYPO3com voted on patch set 2 V +1 12/11/20, 08:53 Completed build in 10m 09s on Fri, 11 Dec, 08:53 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8054

  7. Oli Bartsch updated the commit message in patch set 3 12/11/20, 09:10

  8. Oli Bartsch updated the commit message in patch set 4 12/11/20, 09:12

  9. Oli Bartsch voted on patch set 4 V +1 CR +1 12/11/20, 09:12

  10. TYPO3com voted on patch set 4 V +1 12/11/20, 09:26 Completed build in 08m 43s on Fri, 11 Dec, 09:26 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8057

  11. Wouter Wolters voted on patch set 4 CR +1 12/11/20, 21:24

  12. Benni Mack voted on patch set 4 V +2 CR +2 12/11/20, 22:51

  13. Benni Mack merged patch set 5 12/11/20, 22:51