Review main Merged

67093[TASK] EM: Reduce dependencies when writing t3x files

Benni Mack CR +2 V +2 Normal +78 −136 updated 12/11/20, 18:25

Commit message

The method unpackExtensionFromExtensionDataArray()
is only used once, but with the second argument
set to "null", so all complexity down to EmConfUtility
is reduced.

Same goes for `isValidExtensionPath` in FileHandlingUtility
which is not related to FileHandlingUtility and does not
need to be exposed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 813

  1. Benni Mack uploaded patch set 1 12/11/20, 12:57

  2. TYPO3com voted on patch set 1 V -1 12/11/20, 13:14 Completed build in 16m 33s on Fri, 11 Dec, 01:14 PM Test Summary: 14 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8065

  3. Benni Mack uploaded patch set 2 12/11/20, 13:43

  4. TYPO3com voted on patch set 2 V +1 12/11/20, 13:56 Completed build in 12m 15s on Fri, 11 Dec, 01:56 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8071

  5. Benni Mack updated the commit message in patch set 3 12/11/20, 14:13

  6. Benni Mack updated the commit message in patch set 4 12/11/20, 14:14

  7. Benni Mack updated the commit message in patch set 5 12/11/20, 14:15

  8. TYPO3com voted on patch set 3 V +1 12/11/20, 14:23 Completed build in 09m 42s on Fri, 11 Dec, 02:23 PM Test Summary: 32409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8075

  9. TYPO3com voted on patch set 4 V +1 12/11/20, 14:25 Completed build in 10m 38s on Fri, 11 Dec, 02:25 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8076

  10. TYPO3com voted on patch set 5 V +1 12/11/20, 14:29 Completed build in 14m 16s on Fri, 11 Dec, 02:29 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8077

  11. Oli Bartsch voted on patch set 5 V +1 CR +1 12/11/20, 15:50

  12. Georg Ringer voted on patch set 5 V +2 CR +2 12/11/20, 18:25

  13. Georg Ringer merged patch set 6 12/11/20, 18:25