Review main Merged

67094[BUGFIX] Re-validate changed fields only

Andreas Kienast CR +2 V +2 Normal +68 −48 updated 12/29/20, 15:21

Commit message

Probably since ever, FormEngine validates the whole form when a field
changed or an IRRE item got removed. This patch introduces the following
changes:

- only fields affected by the `change` event get validated
- FormEngineValidation.validate() accepts an optional argument to define
  the container whose fields get validated. If omitted, the whole form
  is validated.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 1727

Show 12 earlier messages
  1. Andreas Kienast uploaded patch set 1 12/11/20, 13:28

  2. TYPO3com voted on patch set 1 V -1 12/11/20, 13:42 Completed build in 11m 07s on Fri, 11 Dec, 01:42 PM Test Summary: 5 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8069

  1. Andreas Kienast uploaded patch set 2 12/11/20, 13:50

  2. TYPO3com voted on patch set 2 V -1 12/11/20, 14:04 Completed build in 10m 57s on Fri, 11 Dec, 02:04 PM Test Summary: 5 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8073

  3. Andreas Kienast commented on patch set 2 CR -2 12/11/20, 15:19

    This needs more brain thrown at. validateField() was never meant to be called from the outside.
  4. Andreas Kienast uploaded patch set 3 12/11/20, 15:27

  5. Andreas Kienast voted on patch set 3 CR 0 12/11/20, 15:37

  6. TYPO3com voted on patch set 3 V +1 12/11/20, 15:38 Completed build in 10m 09s on Fri, 11 Dec, 03:38 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8082

  7. Wouter Wolters voted on patch set 3 CR +1 12/11/20, 21:11

  8. Andreas Kienast commented on patch set 3 CR -2 12/12/20, 10:18

    I have to take another look here.
  9. Andreas Kienast uploaded patch set 4 12/12/20, 12:23

  10. Andreas Kienast voted on patch set 4 CR 0 12/12/20, 12:23

  11. TYPO3com voted on patch set 4 V -1 12/12/20, 12:33 Completed build in 10m 08s on Sat, 12 Dec, 12:33 PM Test Summary: 5 of 32652 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8113

  12. Andreas Kienast uploaded patch set 5 12/12/20, 15:03

  13. Andreas Kienast uploaded patch set 6 12/12/20, 15:09

  14. TYPO3com voted on patch set 5 V -1 12/12/20, 15:14 Completed build in 10m 50s on Sat, 12 Dec, 03:14 PM Test Summary: 2 of 32655 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8120

  15. TYPO3com voted on patch set 6 V -1 12/12/20, 15:20 Completed build in 10m 57s on Sat, 12 Dec, 03:20 PM Test Summary: 1 of 32655 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8121

  16. Andreas Kienast uploaded patch set 7 12/12/20, 15:51

  17. TYPO3com commented on patch set 6 12/12/20, 15:54 Completed build in 56m 35s on Sat, 12 Dec, 03:54 PM Test Summary: 1 of 32655 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8121

  18. TYPO3com voted on patch set 7 V -1 12/12/20, 16:01 Completed build in 09m 36s on Sat, 12 Dec, 04:01 PM Test Summary: 1 of 32655 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8122

  19. TYPO3com voted on patch set 7 V +1 12/12/20, 16:08 Completed build in 25m 54s on Sat, 12 Dec, 04:08 PM Test Summary: 32414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8122

  20. Christian Kuhn voted on patch set 7 V +1 CR +1 12/14/20, 17:38

  21. Andreas Kienast uploaded patch set 8 12/21/20, 16:03

  22. TYPO3com voted on patch set 8 V +1 12/21/20, 16:13 Completed build in 09m 35s on Mon, 21 Dec, 04:13 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8382

  23. Christian Kuhn voted on patch set 8 V +1 CR +1 12/24/20, 10:17

  24. Richard Haeser voted on patch set 8 V +2 CR +2 12/29/20, 15:21

  25. Richard Haeser merged patch set 9 12/29/20, 15:21