Review main Merged

67095[TASK] Revert "[FEATURE] Introduce client-side templating engine"

Benjamin Franzke CR +2 V +2 Hard +0 −263 updated 12/14/20, 17:03

Commit message

This reverts commit 6558a6bdaf61e39df00ad33468cfe20233935b62.

The client side template engine introduced in #91810 is inspired
by lit-html. It was introduced because ES6 modules like lit-html could
not be included in core AMD builds.
With the help of rollup, lit-html can be converted to AMD within
our build process. Therefore our own implementation is removed
in order for lit-html to be introduced afterwards.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 67

  1. Benjamin Franzke uploaded patch set 1 12/11/20, 13:49

  2. TYPO3com voted on patch set 1 V +1 12/11/20, 14:00 Completed build in 10m 42s on Fri, 11 Dec, 02:00 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8072

  3. Benjamin Franzke wrote 12/14/20, 15:13

    Topic set to javascript
  4. Oliver Hader voted on patch set 1 CR +1 12/14/20, 16:03

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 12/14/20, 16:57

  6. Benni Mack voted on patch set 1 V +2 CR +2 12/14/20, 17:03

  7. Benni Mack merged patch set 2 12/14/20, 17:03